fix: 매장운영 워크스페이스 카드 진행률 제거 및 카드 높이 통일 (#80) - #82
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthrough
Changes워크스페이스 카드 진행률 표시 제어
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
작업 내용
작업 결과
작업 배경
get_my_workspacesRPC가 purpose와 무관하게tasks테이블만 집계해progress = 완료 task / 전체 task를 내려줌0/0 완료 · 0%로 표시 → 개념적으로 무의미하고 에러처럼 보임변경 사항
Fixed
min-h로 카드 높이 통일Added / Changed
상세
WorkspaceCard에showTaskProgress = purpose !== 'store-operation'플래그 추가showTaskProgress로 조건부 렌더Link에min-h-[141px](진행률 있는 카드의 자연 높이) 적용해 목록 카드 높이 통일실행화면
테스트
WorkspaceCard단일 파일, RPC·타입 무변경,npm run check통과)리뷰 체크리스트
feature/*->develop, 배포 시develop또는release/*->main)Type/#issue-number/description형식을 따릅니다.console.log, 주석, 임시 코드를 제거했습니다.리뷰 요청사항
0/0으로 여전히 어색). 완료 카운트는 남기는 게 낫다는 의견 있으면 알려주세요.min-h-[141px](진행률 있는 카드의 자연 높이)로 처리했습니다.관련 이슈
Closes #80
Summary by CodeRabbit