Skip to content

perf(FragmentsModels): fill tiles in size-sorted sample order to cut visibility runs #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rihokirss wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(FragmentsModels): fill tiles in size-sorted sample order to cut visibility runs #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...nts/src/FragmentsModels/src/virtual-model/virtual-controllers/virtual-tiles-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,16 @@ export class VirtualTilesController {
mesh.setupTemplates();
}
const step = Math.max(1, Math.floor(this._sampleAmount / 20));
// Fill tiles in descending sample-dimension order (the same order the
// cull sweep uses) instead of file order. A tile's index buffer is
// laid out in insertion order and the per-sample LOD decision is
// driven by screen size, so with size-sorted samples the geometry /
// wires / invisible cut through a tile becomes one or two contiguous
// runs instead of dozens of interleaved ones — and every visible run
// is a separate `geometry.groups` entry, i.e. a separate draw call on
// the main thread. Tile membership itself is unchanged.
for (let i = 0; i < this._sampleAmount; i++) {
this.generateSampleInTiles(i);
this.generateSampleInTiles(this._samplesDimensions[i]);
if (i % step === 0) {
onProgress?.(i / this._sampleAmount);
// Yield the worker thread so progress messages get dispatched
Expand Down