feat: make router HTTP timeout configurable - #26
Merged
TheCoder30ec4 merged 3 commits intoSep 25, 2026
Merged
Conversation
TheCoder30ec4
self-requested a review
September 24, 2026 11:04
Owner
|
There are some merge conflicts reslove those |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Router(timeout=60)and forward it through both Jev routing paths torequest_jsonand ultimatelyurlopen. Catalog downloads use the same setting so constructing a router does not unexpectedly retain a 60-second timeout when a shorter value was requested. Cached catalogs still avoid the HTTP call.The default remains 60 seconds. README documents seconds and distinguishes the underlying HTTP timeout from a total routing deadline; the changelog records the new option.
Closes #13.
Validation: 67 tests and 4 subtests passed,
ruff check .,ruff format --check ., andgit diff --checkpassed. Regression tests mockurlopen, exercising the real Router → Jev → HTTP path for both backends with default and fractional custom timeouts, plus a real catalog parsing path with a custom timeout. Custom-timeout cases failed before the implementation. All tests stayed offline; no API keys or paid requests were used.