fix(chat): stabilize assistant loading state - #1869
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis PR implements an immediate assistant loading placeholder for non-queued user and command submits in ChatPage.vue, refactoring submit logic into shared helper functions, updating the feature spec to "implemented," removing stale planning docs, and expanding test coverage. ChangesAssistant loading placeholder implementation
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant ChatPage
participant messageStore
participant agentPlanStore
participant chatClient
User->>ChatPage: onSubmit / onCommandSubmit
ChatPage->>messageStore: addOptimisticUserMessage
ChatPage->>agentPlanStore: beginTurn (pending assistant placeholder)
ChatPage->>ChatPage: clear input/attachments/skills, schedule scroll
ChatPage->>chatClient: sendMessage
alt send fails
chatClient-->>ChatPage: error
ChatPage->>agentPlanStore: clear pending placeholder
ChatPage->>messageStore: removeOptimisticMessage
else send succeeds
chatClient-->>ChatPage: stream starts
end
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Show the pending assistant placeholder for command submits and clear command composer state before the send route resolves.
Summary by CodeRabbit
New Features
Documentation