[codex] Add Modelsell provider - #2043
Merged
zhangmo8 merged 1 commit intoJul 28, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughAdds Modelsell as a disabled OpenAI-compatible provider preset, validates ChangesModelsell provider integration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zerob13
marked this pull request as ready for review
July 28, 2026 01:56
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/main/provider/basicApiKeyProviders.test.ts`:
- Around line 170-177: Update the AiSdkProvider construction in the basic API
key provider test to pass the required third ProviderLocalePort argument,
reusing the existing locale fixture or a suitable mock. Preserve the current
provider and settings arguments while ensuring the constructor never receives
undefined for its locale dependency.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 22251ea9-1e86-46a6-8142-4e1b7fe57847
⛔ Files ignored due to path filters (1)
src/renderer/src/assets/llm-icons/modelsell.pngis excluded by!**/*.png
📒 Files selected for processing (5)
src/main/provider/defaults.tssrc/renderer/src/components/icons/modelIconRegistry.tstest/main/provider/basicApiKeyProviders.test.tstest/main/provider/defaultProviders.test.tstest/renderer/components/ModelIcon.test.ts
Comment on lines
+170
to
+177
| const provider = new AiSdkProvider( | ||
| createProvider({ | ||
| id: 'modelsell', | ||
| name: 'Modelsell', | ||
| baseUrl: 'https://modelsell.com/v1' | ||
| }), | ||
| createProviderSettings() | ||
| ) |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win
Pass the required locale dependency to AiSdkProvider.
Line [170] constructs AiSdkProvider with only two arguments, but its constructor requires a third ProviderLocalePort argument. Add the existing locale fixture or a suitable mock as the third argument; otherwise type checking should fail and runtime initialization may receive undefined.
This cross-file finding relies on the constructor contract in src/main/provider/providers/aiSdkProvider.ts.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@test/main/provider/basicApiKeyProviders.test.ts` around lines 170 - 177,
Update the AiSdkProvider construction in the basic API key provider test to pass
the required third ProviderLocalePort argument, reusing the existing locale
fixture or a suitable mock. Preserve the current provider and settings arguments
while ensuring the constructor never receives undefined for its locale
dependency.
zerob13
pushed a commit
that referenced
this pull request
Aug 2, 2026
Registers OrcaRouter as a disabled built-in OpenAI-compatible provider, mirroring the Modelsell registration (#2043): a DEFAULT_PROVIDERS entry, the model icon, and a provider-import mapping so configs pointing at api.orcarouter.ai land on the built-in provider instead of a custom one. Models are discovered live from /v1/models, so no provider-db entry is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://modelsell.com/v1and discover models dynamically from/v1/modelsCloses #2042
Implementation
modelsellopenai-completions/ OpenAI-compatible runtimeGET /v1/modelsprovider/installflow; no Modelsell-specific routeThe integration does not hardcode a model catalog or introduce provider-specific request behavior.
Validation
pnpm run formatpnpm run format:checkpnpm run i18npnpm run lintpnpm run typecheckpnpm run icons:checkpnpm exec vitest run --config vitest.config.ts test/main/provider/defaultProviders.test.ts test/main/provider/basicApiKeyProviders.test.ts(19 tests passed)pnpm exec vitest run --config vitest.config.renderer.ts test/renderer/components/ModelIcon.test.ts(6 tests passed)No live authenticated Modelsell API call was performed.
Summary by CodeRabbit
New Features
Bug Fixes
Tests