fix(dispatch): preserve execution intent and single-owner callbacks - #2352
Merged
Merged
Conversation
Pin complete Hub payload intent, alias precedence, context continuity and absent/false/zero semantics without inventing runtime or workspace defaults. Refs #2350. Co-authored-by: Codex <codex@vectorcontrol.tech>
Advertise ownership-aware callback capabilities, reject unconfigured direct callbacks before admission, retain the original reporter across replays and prevent Desktop-owned runs from emitting a second Edge callback stream. Refs #2350. Co-authored-by: Codex <codex@vectorcontrol.tech>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2350.
Compatibility and non-goals
Acceptance evidence
Tested head:
aab5f0623664942bb54189d021d56d7149ca3033; tree:a28b1e388be60c0dad38991d7bdbd87d701cb919.go test -p 2 ./... -short -count=1 -cpu=4 -timeout=10mtest:ciRegression evidence includes PostgreSQL
22P02for an empty-string UUID comparison, Desktop POST uncertainty being falsely marked failed, and pending text stranded before typed output. All are green after the changes. The local full L1 initially exposed a helper hardcoding the default PostgreSQL endpoint; it now reads the same test configuration as TestMain, and the entire L1 passed against isolated non-default fixture services.The initial GitHub run caught a new sleep, Hub complexity/style lint, and an outdated Edge L2 ownership fixture. These were fixed rather than bypassed: direct preflight and post-admission response handling are separate, callbacks are explicitly configured/owned in the fixture, and three old sleep grace windows were replaced by event waits with a strictly smaller budget. All seven required checks passed individually on run 34072040715:
validate,go-edge,go-hub,windows-go,windows-frontend,backend-required,frontend-required. Native Windows Hub verification is left to its required CI lane because the local CGO environment cannot run that suite; this is not a native-Windows local-pass claim.