ci(node): bump Node runtime from 22 to 24 - #2354
Merged
Merged
Conversation
把三处 workflow 的 NODE_VERSION、web 镜像 builder 基础镜像和本地要求一起升到 Node 24,并给 app/package.json 补 engines.node 下界,避免本机 / CI / 镜像三个 消费者各说一套。仓库既有的 verify-action-runtimes.py 本来就按 node24 allow-list 校验 action 运行时,这次让实际运行时与它对齐。 验证(本机 Node v24.14.0 + pnpm 10.32.1): - pnpm install --frozen-lockfile:lockfile up to date - pnpm -r typecheck:shared / workbench / web / desktop / mobile-rn 全过 - docker build -f app/Dockerfile(node:24-alpine,corepack 0.35.0)成功,镜像 83.8MB - app/desktop 按 CI 原样跑 vitest.desktop-ts-ci.config.ts:32 files / 371 tests 全过 - verify-action-runtimes / verify-ci-gates / verify-doc-ssot / verify-conventions 全 PASS 未跑:完整 CI(windows-frontend、e2e、Go 侧 job)与镜像推送,留给 PR 门禁。 Co-authored-by: Cursor <cursor@vectorcontrol.tech>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
把 Node 运行时从 22 升到 24:三个 workflow 的
NODE_VERSION、web 镜像的 builder 基础镜像、README 与 developer-quickstart 的本地要求一起升,并给app/package.json补engines.node下界,避免本机 / CI / 镜像三个消费者各说一套。仓库既有的
scripts/verify/verify-action-runtimes.py本来就按 node24 allow-list 校验 action 运行时(失败信息即 "not on the node24 allow-list"),这次让实际构建/测试运行时与该门禁对齐。改动
.github/workflows/checks.yml、release.yml、release-readiness.yml:NODE_VERSION: "22"→"24"app/Dockerfile:builder 阶段node:22-alpine→node:24-alpineapp/package.json:新增engines.node: ">=24"(advisory;.npmrc未开engine-strict)README.md、docs/developer-quickstart.md:本地要求 Node 22+ → 24+验收证据(本机 Node v24.14.0 + pnpm 10.32.1,Windows)
pnpm install --frozen-lockfile:lockfile up to date,resolution skippedpnpm -r typecheck:shared / workbench / web / desktop / mobile-rn 全过docker build -f app/Dockerfile app:成功,镜像 83.8MB;node:24-alpine内 corepack 0.35.0 存在,corepack enable && corepack prepare pnpm@10 --activate正常working-directory: app/desktop)跑:vitest.desktop-ts-ci.config.ts32 files / 371 tests 全过,vitest.desktop-tsx-ci.config.ts23 files / 136 tests 全过verify-action-runtimes.py/verify-ci-gates.py/verify-doc-ssot.py/verify-conventions.py全 PASS未跑项
windows-frontend、e2e、Go 侧 job)由本 PR 门禁执行合并影响
app/Dockerfile与app/package.json都在cd-web.yml的 master push 路径过滤内,合并后会构建并推送新的 web 镜像(sha-<sha>-{amd64,arm64}与 multi-arch manifest tag)。镜像发布不等于部署,替换运行实例仍走各自的部署流程。顺带发现(不在本 PR 修)
pnpm test(app/vitest.config.ts)在 master 上失败:desktop/src/hooks/executionIntent.test.ts用resolve(process.cwd(), '../../tests/fixtures/dispatch/execution-intent.json'),从app/执行会解析到仓库外;CI 因working-directory: app/desktop不受影响。建议改为相对测试文件解析。checks.yml中 desktop lint 步骤的注释称 desktop "0 errors but 4 warnings",实测eslint src为 5 个no-explicit-anyerror + 4 warning,而该步是continue-on-error: true:注释已过期,且这个 advisory 门禁正在放行真实 error。