Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,22 +1,37 @@
.SILENT:
.PHONY: test

# Install dependencies
install:
npm install

# Launch watch
watch:
./node_modules/.bin/webpack --watch --mode=development

# Build lib
build:
./node_modules/.bin/webpack --mode=production

# Launch demo
start: demo-client demo-server

# Launch demo client
demo-client:
php -S 0.0.0.0:8000 -t .

# Launch demo server
demo-server:
node ./demo-server.js 8002

# Lint and code style fix
lint:
./node_modules/.bin/eslint src/* --ext .js,.json --fix

# Test
test:
node_modules/.bin/mocha

# Publish package
publish: build
npm publish . --access public
125 changes: 104 additions & 21 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"engines" : {
"node" : ">=8.0.0"
"engines": {
"node": ">=8.0.0"
},
"keywords": [
"netcode",
Expand All @@ -32,6 +32,7 @@
"babel-loader": "^7.1.5",
"babel-preset-env": "^1.7.0",
"eslint": "^5.8.0",
"mocha": "^5.2.0",
"webpack": "^4.25.1",
"webpack-cli": "^3.1.2"
}
Expand Down
14 changes: 11 additions & 3 deletions src/encoder/codec/LongStringCodec.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,13 @@ export default class LongStringCodec extends Codec {
*/
encode(buffer, offset, data) {
const view = new DataView(buffer, offset, this.getByteLength(data));
const { length } = data;

view.setUint16(0, data.length);
view.setUint16(0, length);

Array.from(data).forEach((letter, index) => view.setUint16(2 + (index * 2), letter.charCodeAt(0)));
for (var index = 0; index < length; index++) {
view.setUint16(2 + (index * 2), data[index].charCodeAt(0));
}
}

/**
Expand All @@ -28,7 +31,12 @@ export default class LongStringCodec extends Codec {
decode(buffer, offset) {
const view = new DataView(buffer, offset);
const length = view.getUint16(0);
const chars = new Array(length);

return new Array(length).fill(null).map((value, index) => String.fromCharCode(view.getUint16(2 + index * 2))).join('');
for (var index = 0; index < length; index++) {
chars[index] = view.getUint16(2 + index * 2);
}

return String.fromCharCode(...chars);
}
}
7 changes: 3 additions & 4 deletions src/encoder/codec/StringCodec.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,12 @@ export default class StringCodec extends Codec {
*/
encode(buffer, offset, data) {
const view = new DataView(buffer, offset, this.getByteLength(data));

view.setUint8(0, data.length);

const { length } = data;

view.setUint8(0, length);

for (var index = 0; index < length; index++) {
view.setUint16(1 + (index * 2), data[index].charCodeAt(0))
view.setUint16(1 + (index * 2), data[index].charCodeAt(0));
}
}

Expand Down
Loading