Skip to content

Fix makeDocHandleReactive output being affected when changing clone - #1479

Merged
kasbah merged 2 commits into
mainfrom
kb/clone-projection
Sep 11, 2026
Merged

kasbah merged 2 commits into
mainfrom
kb/clone-projection

Conversation

@kasbah

@kasbah kasbah commented Sep 10, 2026

Copy link
Copy Markdown
Member

This is a manifestation of a similar issue as am-solid-primitives' automerge/automerge-repo#721 in our own makeDocHandleReactive.

@kasbah
kasbah added this pull request to stack #1480 September 10, 2026 13:00
@kasbah kasbah changed the title makeDocHandleReactive output affected when changing clone Fix makeDocHandleReactive output being affected when changing clone Sep 10, 2026
@kasbah
kasbah marked this pull request as ready for review September 10, 2026 14:39
@kasbah
kasbah requested a review from epatters September 10, 2026 15:49
@kasbah
kasbah force-pushed the kb/clone-projection branch from 91fada3 to 5839027 Compare September 10, 2026 16:16
@kasbah
kasbah force-pushed the kb/clone-projection branch from 5839027 to 552d0e8 Compare September 10, 2026 16:32
@kasbah
kasbah force-pushed the kb/clone-projection branch from 552d0e8 to e9aebdb Compare September 10, 2026 17:05
@kasbah
kasbah removed this pull request from stack #1480 September 10, 2026 17:06
@kasbah
kasbah added this pull request to stack #1483 September 10, 2026 17:06
@kasbah
kasbah force-pushed the kb/clone-projection branch from e9aebdb to 15a7fa9 Compare September 10, 2026 17:08
@epatters epatters added bug Something isn't working frontend TypeScript frontend and Rust-wasm integrations labels Sep 10, 2026

@epatters epatters left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate to make a full clone on every document change, but better to be correct than efficient while we await a proper upstream fix.

@kasbah
kasbah force-pushed the kb/clone-projection branch from 15a7fa9 to 6cc6966 Compare September 11, 2026 08:51
Base automatically changed from kb/rich-text-apply-patches to main September 11, 2026 08:59
@kasbah
kasbah force-pushed the kb/clone-projection branch from 6cc6966 to 858f524 Compare September 11, 2026 08:59
@kasbah
kasbah merged commit a05062c into main Sep 11, 2026
17 checks passed
@kasbah
kasbah deleted the kb/clone-projection branch September 11, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend TypeScript frontend and Rust-wasm integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants