Conversation
|
@ZenAlexa is attempting to deploy a commit to the luokerenx4's Team Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Oct 1, 2026
ZenAlexa
marked this pull request as ready for review
October 1, 2026 22:46
# Conflicts: # ui/src/components/credentials/CredentialModal.tsx
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The workspace needs a compact desktop rhythm and stable control geometry across navigation, settings, menus, and trading data. The reported regressions include adjacent highlighted rows touching, Tools headers separating from their contents, oversized navigation, misaligned disclosure actions, native selects with a different visual contract, and chart notices moving surrounding content.
This is the shared-interface boundary extracted from #1704. The base is
devat4813c1b89.What changed
Shared controls and layout
Data stability and motion
Review boundary and commits
152a7a1aa: shared compact controls, navigation, dialogs, settings, and their consumers.ce7d5bc3d: account and chart state preservation, shared effective-palette resolution, and the existing interface guide.0b2ae4749: aligned workspace child rows, stable menu summaries, cascading gaps, and the shared schedule controls.e9a2f7336: shared toolbar and News sizing, touch action targets, and session-menu focus restoration.Merged the current upstream cadence editor through
d72b55268. The upstream editor continues to own drafts, Save, Cancel, conflict reload, and retries.The model-identity PR owns readable model names, manufacturer resolution, and catalog revalidation. The interface-profile PR owns the new Studio and Outline styles and the redesigned Broker Classic material. This PR keeps the current model-display contract and the existing profile list.
Review the shared primitives and tokens first, then the migrated settings and workspace consumers, and finally the account and chart behavior. Backend trading execution, order semantics, and provider routing retain their existing owners.
October 2 control refinement
This follow-up changes six files, with 16 additions and 20 deletions. It adds no dependency or new runtime abstraction.
Short-viewport and forced-color fixes
Commit
712a8f96bremoves the local overflow override from confirmation dialogs and adds a platform forced-color focus outline. Shared AlertDialog content continues to own height limits and vertical scrolling. The patch changes two existing files, with eight additions and one deletion.At 640 × 240, the confirmation popup has a 208px viewport and 297px of content. Focusing its actions scrolls the popup to expose both buttons. Tab reaches Delete; Escape closes the dialog and returns focus to the original session action. The scenario ends with cancellation.
With forced colors active in the Default profile, keyboard focus renders a 2px solid system-color outline with a 2px offset. The rule uses the platform color and applies through the shared stylesheet.
Related PRs and integration
Each branch targets
devand includes upstream4813c1b89. Each branch builds independently. Shared consumers overlap. Suggested merge order: #1730, #1728, #1729. Integrate each subsequent branch with the merged changes and preserve each component's presentation owner.Composed integration reference
eff62db08contains all three updated PR heads and the shared-file resolutions. The boundary-fix captures above use its matching production-demo source tree. The existing galleries below were captured on 2026-10-02 from integration5eae22a85, using supplied demo data. Desktop captures use 1280 × 720; narrow captures use 390 × 844. The confirmation boundary captures use 640 × 240. Each caption identifies the view and state.Refreshed screenshots
Touch toolbar alignment
Workspace action targets
News control rows
Current Tools, Overview, Quant, and Prediction views
Quant and Prediction captures cover the demo workspace entry. The managed Prediction Studio process and live research execution are outside the demo verification.
Verification
The current update was checked on 2026-10-02 against upstream
devat4813c1b89.git diff --checkpassed.The two branch suites initially ran concurrently and each reached the default 5-second timeout in the existing older-record Office scenario. Sequential runs use the same command and unchanged timeout:
NODE_ENV=test node scripts/run-tests.mjs --path ui/src. Their final results are recorded above.Interactive review
Open a session action menu, choose Archive, then cancel. Focus returns to the same action trigger. Repeat with Escape and reduced motion enabled. Move through nested runtime and model menus using the keyboard. Resize to a narrow touch viewport and inspect toolbar wrapping. Change chart periods and themes, expand Tools groups, and repeat a settings save.
Screenshots record resting states. Press feedback, disclosure continuity, focus return, loading transitions, and chart-view preservation need interaction in the running build.
The production build emits the existing large-chunk advisory. Bundle partitioning remains a separate performance boundary.
GitHub
clean-buildpassed on this update. Vercel preview deployment requires authorization from the repository’s Vercel team.