Repository navigation
走行シミュレーション用 gRPC クエリ GetTrainRoute を追加 - #1568
Merged
Merged
Conversation
gRPCProto submoduleを更新し、EstimateArrivalTimes RPCと EstimatedArrivalResponse/Route/Stopメッセージを追加。 gRPCコントローラに既存のestimate_route_arrival_timesユースケースへの 結線を実装し、経路ごとにグルーピングしたレスポンスを返す。 Closes #1562 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
A駅→B駅を指定列車種別(line_group_id)で走行する際の各駅情報を 1リクエストで返すGetTrainRouteを実装。各駅に停車/通過フラグ・ 直前駅からの距離(m, Haversine)・最高速度/加減速度(SI単位)を 付与し、MobileAppのuseSimulationModeが端末内で行っていた 経路・速度プロファイル準備をサーバ側に集約する。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthrough
Changesget_train_route 機能追加
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…-estimation-via-grpc # Conflicts: # stationapi/src/presentation/controller/grpc.rs
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 of 10 tasks
7 of 10 tasks
This was referenced Jul 3, 2026
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
A駅→B駅を指定列車種別(
line_group_id)1本で走行する際の各駅情報を 1リクエストで返す gRPC クエリGetTrainRouteを追加します。各駅に停車/通過フラグ・直前駅からの距離(m)・最高速度/加減速度(SI単位)を付与し、MobileApp のuseSimulationModeが端末内で行っていた経路・速度プロファイル準備をサーバ側に集約します。変更の種類
変更内容
stationapi/proto: gRPCProto submodule を更新。GetTrainRouteRPC、TrainRouteSegment/GetTrainRouteRequest/TrainRouteResponseメッセージを追加use_case/dto/simulation.rs(新規): 走行速度・加減速度の定数とresolve_speed_profile(line_type, is_bus, kind)。MobileApp のsimulationMode定数と一致。単体テスト付きuse_case/traits/query.rs/use_case/interactor/query.rs:QueryUseCase::get_train_routeを追加。既存のget_stations_by_line_group_idとhaversine_distanceを再利用し、新規SQLなしpresentation/controller/grpc.rs:get_train_routeハンドラを追加テスト
cargo fmt --all -- --checkが通ることcargo clippy -- -D warningsが通ることcargo test(SQLX_OFFLINE=true)が通ること関連Issue
Refs #1564
Supersedes #1565
スクリーンショット(任意)
Summary by CodeRabbit
line_group_idが未指定の場合は入力エラー(必須)を返します。