fix: train outcome recording - #133
Merged
Merged
Conversation
Two samples pinned HotChocolate.AspNetCore to 15.1.18 with VersionOverride while the repo's own pin moved to 16.6.6 and Trax.Dashboard came to require 16.6.2, so neither sample could restore against a current Dashboard.
…olate 16 Dashboard 3432701 dropped VersionOverride="15.1.18" from the GameServer scheduler and the SignalR dashboard sample, but Samples still pins the published Trax.Dashboard 1.15.0, whose Trax.Api 1.38.0 is built on HotChocolate 15. Without the override those projects resolve HotChocolate.AspNetCore 16.6.6 beside 15.1.16 for everything else, and their committed lockfiles still said 15.1.18, so the locked-mode restore in CI would have failed as well. The override comes out in the change that moves the Dashboard pin to a release built on HotChocolate 16.
AGENTS.md now points the code this branch touched at the central decisions that govern it, and its counts of central ADRs and convention guards match the index and the Tests.Meta folder.
The check arrives with the new Trax.Mediator; until Samples pins it, the samples' hosts do not run it.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR is included in version 1.33.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.