Introduce EditContext to simplify parameter editing code paths - #255
Merged
Merged
Conversation
rreichenbach
approved these changes
Sep 8, 2026
rreichenbach
left a comment
Collaborator
There was a problem hiding this comment.
This seems to work with everything I tried.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #253.
A MIDI-CC advanced mapping has a physical-control range. It does not change the plugin parameter range.
Before this PR, a mapping could narrow the parameter grid and could clamp the local value when MOD changed the mapping. This could make the LCD show a value different from MOD.
Changes
EditContextfor the parameter, commit function, and editor range.common.parameter_stepstocommon.parameter_editing.User result
Out-of-scope
Integer value coercion for logarithmic parameters is separate from this PR. It is tracked in #254.