Accept revert/revert-layer/unset on every property - #203
Merged
TylerBrinks merged 1 commit intoJul 23, 2026
Merged
Conversation
inherit, initial, revert, revert-layer and unset are CSS-wide keywords,
valid on every property (CSS Cascade 4 7.3; revert-layer is Cascade 5).
OrGlobalValue already accepted all five, but OrDefault - which most
property converters use - accepted only inherit and initial, so
"color: unset", "display: revert" and "white-space: revert-layer" were
rejected while "color: inherit" worked.
Route OrDefault through OrGlobalValue, and extend the defaulted overload
with the same three keywords. Misspellings ("un-set", "revertlayer")
remain rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
revert,revert-layerandunsetare rejected on most properties, whileinheritandinitialwork:All five are CSS-wide keywords, valid on every property (CSS Cascade 4 §7.3;
revert-layeris Cascade 5).OrGlobalValuealready accepts all five, but the widely-usedOrDefaultaccepts onlyinheritandinitial:so any property converter built with
OrDefault(the majority) rejects the other three.Fix
Route
OrDefaultthroughOrGlobalValue, and extend the defaulted overload (OrDefault<T>) with the same three keywords. TheKeywords.Revert/RevertLayer/Unsetconstants already exist.Tests
15 cases in
PropertyTests/GlobalKeywordPropertyTests.cs: all five keywords acrosscolor,display,text-align,float,white-space,font-weight,line-height; plus misspellings (reverts,un-set,revertlayer) that must stay rejected, confirming the accepted set widened without loosening the grammar.12 fail on
master. The full suite (1263 existing tests) stays green, and all seven target frameworks build with no new warnings.