Add the hyphens property - #204
Merged
TylerBrinks merged 1 commit intoJul 23, 2026
Merged
Conversation
hyphens: none | manual | auto (CSS Text 3 6.1) had no support. Add the Hyphens enum, its keyword map and converter, the "manual" keyword, and an inherited HyphensProperty registered in PropertyFactory, following the same enum/Map/converter pattern as the other keyword text properties. The initial value is manual.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Adds the
hyphensproperty (CSS Text 3 §6.1):It is inherited, with an initial value of
manual.Implementation
Follows the existing keyword-property pattern (e.g.
white-space): aHyphensenum, aMap.HyphensModesdictionary, aConverters.HyphensConverter, the newmanualkeyword, and an inheritedHyphensPropertyregistered inPropertyFactory.Tests
7 cases in
PropertyTests/TextProperty.cs: the three keywords (plus a case-insensitivity check) parse and round-trip;always, a number, and two keywords together are rejected.The four legal-value tests fail on
master(the property is unknown there). The full suite (1263 existing tests) stays green, and all seven target frameworks build with no new warnings.