Skip to content

Investigate possible bugs in top-level-await tests #1696

Description

@cspotcode

@ejose19 Can I get a review of our top-level-await tests from you, since you wrote the initial implementation?

In the original PR for top-level await:
https://github.com/TypeStrong/ts-node/pull/1383/files

I see a couple things I'm unclear on:

When running upstream tests, we do not await, so I think failures will be ignored:
https://github.com/TypeStrong/ts-node/pull/1383/files#diff-1d9efcccb250238d73480e5c49afae61494dd3103e9a16c38d36979f27c6ff90R2165

When calling runAndWait we also do not await. Why is that?
In nodejs's tests, there is await

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions