Skip to content

revert addition of package.json "exports" because it is a breaking ch…#1027

Merged
cspotcode merged 1 commit into
masterfrom
ab/revert-package-exports
May 3, 2020
Merged

revert addition of package.json "exports" because it is a breaking ch…#1027
cspotcode merged 1 commit into
masterfrom
ab/revert-package-exports

Conversation

@cspotcode

Copy link
Copy Markdown
Collaborator

…ange and requires more thought

Fixes #1026.

I would still like to merge #1026 eventually, but for an immediate fix, this seems the safest.

@addaleax addaleax left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is obviously also good for me! :)

@cspotcode

Copy link
Copy Markdown
Collaborator Author

@addaleax I appreciate the very quick bug report and PR! The medium post you linked mentioned issues with importing ./package.json and I think I need more time to read about the implications. But then I'll definitely come back to #1026 and get it merged.

@cspotcode cspotcode merged commit 9fb567a into master May 3, 2020
@addaleax

addaleax commented May 3, 2020

Copy link
Copy Markdown

@cspotcode #1026 doesn’t really apply as a patch anymore, so I’ve deleted the branch, but yeah, if you add an "exports": key, making sure that all possible entry points are listed should help a lot :)

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 80.709% when pulling 2bee85e on ab/revert-package-exports into 6fc4298 on master.

1 similar comment
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 80.709% when pulling 2bee85e on ab/revert-package-exports into 6fc4298 on master.

@cspotcode cspotcode deleted the ab/revert-package-exports branch May 9, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants