Orchestration - #24
joshuaRiefman wants to merge 20 commits into
Conversation
jonahjlee
left a comment
There was a problem hiding this comment.
This PR is too large for me to review in detail, but I read the docs and skimmed through the code and it looks good.
Committing API tokens feels strange even though it's safe in our case...
In terms of the orchestration module: it seems to be working well, but I think that it's a more complex solution that what we really need, since we will probably not be running offline Sunbeam very often. Regardless, there are lots of good changes and other additions in this PR. Thanks for all your work!
There was a problem hiding this comment.
Maybe this should be removed, or made to point to ALEMBIC.md
| name = "FSGP_2024_Day_1" | ||
| vehicle = "Brightside" | ||
| description = "First day of FSGP 2024 at NCM Motorsports" | ||
| stages = ["Power", "Efficiency"] |
There was a problem hiding this comment.
The stages for FSGP 2024 day 1 should match what's currently in realtime for this to work.
| ports: | ||
| - "5432:5432" | ||
| volumes: | ||
| - ./data/postgresql:/var/lib/postgresql/data |
There was a problem hiding this comment.
I know it's not orchestration related but can we change this to - pgdata:/var/lib/postgresql/data? It makes running on WSL easier.
|
|
||
| volumes: | ||
| telemetry_db_data: | ||
| telemetry_db_data: |
Agreed. I could remove them but then we'd have to deal with Agreed that it is definitely more complex than what I set out to do, but I've been struggling to find places to reduce the complexity and I'd be happy to follow through with any suggestions.
I used to think this too, but my opinion has flipped. We'll be using offline Sunbeam quite often in the process of developing Sunbeam and especially for any future data analysis. |
Good points! I suppose changes to the derivation of values or additions of new ones would mean we would want to rerun the historical pipeline.
I'll keep this in mind - maybe I'll have better ideas when I've worked more with the repo hands-on. |
[FEAT/FIX/DOCS]: Pull Request Name
What's New
[What has been added?]
Bugfixes
[Have you added any bug fixes?]
Deprecated/Removed
[Has anything been removed or deprecated?]
Dependencies
[Any changes in dependencies?]
Notes
[Anything else relevant?]