docs: wrap long line in mod_puls_routing example to fix Rd line-width… - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3.
During investigation of Issue #3, three of the four reported items were found to be environmental on the reviewer's side (stale installed package) rather than actual code bugs:
rfaR/peakStages— no reference topeakStagesin current package codescale_hydrograph()— example already uses JMD data, runs cleanly underexample()mod_puls_routing()— example is self-contained, runs cleanly underexample()rfaR-Realization-Conceptual.Rmdvignette — builds cleanly underdevtools::build_vignettes()The one real issue was an
R CMD checkNOTE onmod_puls_routing.Rdflagging a line over 100 characters in the\examplesblock.Changes
Wrapped the long line in
mod_puls_routing()'s@examplesblock to stay under 100 characters.Testing
R CMD checknow reports 0 errors, 0 warnings, 0 notesexample("mod_puls_routing")runs cleanly end-to-end