Skip to content

Merge Tt and USEPA versions - #2

Open
leppott wants to merge 47 commits into
USEPA:mainfrom
leppott:main
Open

leppott wants to merge 47 commits into
USEPA:mainfrom
leppott:main

Conversation

@leppott

@leppott leppott commented Feb 11, 2025

Copy link
Copy Markdown
Collaborator

Update prior to publication.

* update: Update Shiny app
    + QC Thresholds, Edit Thresholds, Issue #148
* fix: Shiny custom edit thresholds
    + Change default config to version without env statement
* style: Update Report_SiteSummary spacing
- style: Update formating in global.R
- refactor: Change order, locations, and names of tabs in Shiny app,
  Issue \#152
* refactor: Update base config file, Issue #153
* refactor: Update ThresholdsCheckWorksheet links in Shiny, Issue #153
- refactor: Shiny app updates
  - Main tab name Troubleshoot to Troubleshooting
  - Date format box text on HOBOware reformat
  - Move QC Tips from Main Functions to About
- refactor: Update config (lakes) in library and Shiny, Issue \#153
- refactor: Shiny app updates
  - Update some images
  - Update text
* refactor: Update formatminiDOT function to remove columns with all NA values
    + Fixes issue with ContDataQC QC function
* refactor: Update Thresholds tab order
* refactor: Add text to Main - Import tab
* refactor: Shiny tab text updates
    + Check Input
    + Main
    + Organize Files
    + HOBOware Reformat
* refactor: Rename Sensor File Modification to Automated Reformatting
    + Add About tab
- refactor: Shiny tab text updates
  - miniDOT concatenate
  - miniDOT reformat
  - Advanced (new tab)
  - Formatting Files
- refactor: Change widths on Edit Thresholds tab
  - Some boxes too small
- refactor: Update period stats plots with legend
  - inst\_PeriodStats.rmd
- fix: Update example code in PeriodStats
- refactor: Edits to Shiny tabs
* refactor: Added config file display name
   + Main Functions - Run Functions
   + Main Functions - QC Thresholds - Upload Custom Thresholds
* refactor: Add text for tab references instead of links
* fix: Change stats N from total records to non-NA records, Issue #140
    + length(x) to sum(!is.na(x))
    + SumStats.updated.R
    + fun.Stats.R
    + fun.Stats.File.R
    + fun.PeriodStats.R
* refactor: Update stats plots with legend
    + fun.Stats.R
    + fun.Stats.File.R
* refactor: Use USEPA template
* refactor: QC function to move QC columns, Issue #154
    + Flag. and Comment.MOD cols next to measurement columns
    + Ignore Date, Time, and Date.Time
- refactor: Move version number from title to about, Issue \#161
- refactor: Add file identifiers to download links, Issue \#160
* refactor: Apply revised USEPA template (2023-12-15), Issue #155
- refactor: Replace images in Shiny, Issue \#157
- refactor: Shiny app add “exit” tags to html links, Issue \#159
- refactor: Text updates on most tabs of Shiny app
- refactor: Remove Troubleshooting info in Shiny app, except for Console
- refactor: Figures of tables to tables in Shiny app, Issue \#157
- refactor: Update Shiny app text and tables, Issue \#156
- refactor: Update Shiny app exit links, Issue \#159
* refactor: Update Shiny app
    + typos
    + indents
    + replace some tables with figures
- fix: Update minidoct_cat() function to display midnight values, Issue
  \#163
- refactor: Update config file, Issue \#162
  - threshold for flat tolerance sensor depth from 0.0 to 0.01
  - ext
    - config.ORIG.R
    - config.COOL.R
    - config.WARM.R
    - config.Lakes.metric.R
  - shiny-examples
    - Config_Default.R
    - Config_default.zip
    - Config_Lakes_meters.zip
    - Config_Lakes_metric.R
    - Config_Template.R
    - Config_Template.zip
    - Config.R
* refactor: Add error message for bad files in miniDOT concatenate in Shiny app
- refactor: Add pop up on HOBOware reformat for date time conversion
  - Success and failure
- fix: Update USGS gage data retreival for midnight entries, Issue \#165
  - Same as miniDOT Issue \#163
- fix: Update Shiny file upload parameter check to use names from
  config, Issue \#166
* docs: Build vignettes
- docs: Add vignettes to inst folder so can link to from GitHub
* refactor: Remove extra mainPanel on 3c (Main_QCThresh_EditThresh)
    + Reclaim blank screen space
    + Space reserved for mainPanel not being used
* refactor: Update thresholds display table
    + DO Spike
    + Add DO Adj, DO % Sat, and Salinity
* refactor: Text edits of flags in Report_QC.rmd
* refactor: Update Report_QC.rmd in shiny rmd folder
2024-12-23

- refactor: Update workflow step 2 text (3a1_About)
- refactor: Update Excel file in Shinay 3c3_QCThresh_Eval
- fix: Update link to Shinay 3c3_QCThresh_Eval
- fix: Update shinyalert for HOBO reformat for multiple files
- fix: Update shinyalalert for HOBO reformat, Issue \#164
  - Shiny removes empty directories, add ‘remove.text’ file before
    upload
* refactor: Fix typo in Report_QC.rmd, Issue #167
    + inst/rmd
    + inst/shiny-examples/ContDataQC/rmd
- refactor: Update HOBO U20 example data file

@m-pennino m-pennino left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@m-pennino m-pennino left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@m-pennino m-pennino left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fine

@m-pennino m-pennino left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fine.

* fix: Manual merge changes from GitHub and local.  Out of sync.
    + NEWS.rmd
    + DESCRIPTION
    + fun.QC.File.R
    + zfun.ContDataQC.R
* refactor: Add 10 extra generic variables
    + extdata\config.ORIG.R
    + R\config.R
    + fun.QC.R
    + fun.QC.File.R
    + rmd\Report_QC.rmd
* refactor: Change config.ORIG.R to be a custom file
* fix: Update Global to account for change in config.ORIG.R
    + Add environment statement that was commented out in the last commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants