Skip to content
This repository was archived by the owner on Jun 29, 2026. It is now read-only.

feat(ci): prefer hosted runners, fallback to self-hosted via reusable workflows - #48

Merged
polyipseity merged 8 commits into
mainfrom
feat/prefer-hosted-fallback-reusable
Jan 21, 2026
Merged

feat(ci): prefer hosted runners, fallback to self-hosted via reusable workflows#48
polyipseity merged 8 commits into
mainfrom
feat/prefer-hosted-fallback-reusable

Conversation

@polyipseity

Copy link
Copy Markdown
Member

Summary

  • Add reusable workflows for release, docker, and checks; callers now use hosted-first → self-hosted fallback.
  • New files: .github/workflows/{release,docker,check}-reusable.yml.
  • Callers updated: .github/workflows/{release,docker,check}.yml call reusable workflows for try/fallback.
  • Fallback gating uses if: ${{ failure() }} so fallback runs only when the try job fails.
  • continue_on_error is passed into reusable workflows as an input and applied at job level.
  • Clarifying comments added about PR UI duplication and cosmetic failures when fallback runs.
  • Fallback runs_on set to self-hosted.

Notes

  • Branch: feat/prefer-hosted-fallback-reusable
  • Expect PR UI to show duplicated/expanded checks when fallback executes; this is cosmetic (documented in comments).

@polyipseity polyipseity added the enhancement New feature or request label Jan 19, 2026
@polyipseity polyipseity self-assigned this Jan 19, 2026

@flandia flandia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ready for merge?

@polyipseity

Copy link
Copy Markdown
Member Author

Yes, except that maybe we could use a better name than *-reusable.yml (seems to wrongly imply the workflows are reusable in some way, whereas it reality it just avoids duplicating the same steps twice).

@polyipseity
polyipseity force-pushed the feat/prefer-hosted-fallback-reusable branch from c4930e6 to 317405e Compare January 21, 2026 02:55
@polyipseity
polyipseity merged commit 317405e into main Jan 21, 2026
13 checks passed
@polyipseity
polyipseity deleted the feat/prefer-hosted-fallback-reusable branch January 21, 2026 02:59
@polyipseity

Copy link
Copy Markdown
Member Author

Renamed the workflow to a better name (shared workflow), and the MongoDB step is from the commented out step (https://github.com/USThing/template-api/pull/48/changes#diff-55f05888fd854d9962bdd4d8ccf23a07b610990f58174397b2586b58f8937428L59-L61).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants