add popup box - #115
Merged
Merged
add popup box#115
Conversation
Deploying with
|
| Latest commit: |
a7fb0f9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e066c53c.unirep-trusted-setup.pages.dev |
| Branch Preview URL: | https://prompt-after-post.unirep-trusted-setup.pages.dev |
kittybest
marked this pull request as ready for review
October 4, 2023 09:38
Member
Author
I think the popup to gist post works? oh but it's private so I need to make them public right? I think is the problem of the previous PR #99. I will edit there. == UPDATED == |
Member
Author
|
Problem found: gist will post without including contributionHashes since the ceremony is not loaded yet. Will fix it later. |
…rash due to twitter error
Author
|
Member
ChialiT
approved these changes
Oct 8, 2023
Member
|
there is few redirect ui under the overlay, I think its ok for now. |
vivianjeng
added a commit
that referenced
this pull request
Oct 8, 2023
* add backend .env.example * store github access_token in localstorage * post on gist * tweet a post (now the text is too long) * update twitter post message * chore: remove comments * update node 16 to 18 in dockerfile * add redirect_uri in env.example file, remove unused code * change the tweet url to frontend url * add og stuff in html * add og xmlns in header * modify contributionName to Anon/name chosen by user/github username/discord username * store contributionName to localStorage * update twitter post * modify gist contribution text * fix frontend bug * fix twitter button bug after merge * add popup box (#115) * apply suggestion for text change * chore(frontend): add og content and image (#127) --------- Co-authored-by: Ya-wen, Jeng <vivi432@yahoo.com.tw>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Popupcomponent