Skip to content

add popup box - #115

Merged
vivianjeng merged 9 commits into
share-snsfrom
prompt-after-post
Oct 8, 2023
Merged

vivianjeng merged 9 commits into
share-snsfrom
prompt-after-post

Conversation

@kittybest

@kittybest kittybest commented Oct 4, 2023

Copy link
Copy Markdown
  • create Popup component
  • read gist post response, create the post url, and put it into popup box
  • read twitter post url from the return url, and put it into popup box

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 4, 2023

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a7fb0f9
Status: ✅  Deploy successful!
Preview URL: https://e066c53c.unirep-trusted-setup.pages.dev
Branch Preview URL: https://prompt-after-post.unirep-trusted-setup.pages.dev

View logs

@kittybest
kittybest marked this pull request as ready for review October 4, 2023 09:38
@vivianjeng

Copy link
Copy Markdown
Member

can it also solves popup to gist post?
and the gist post is now secret
截圖 2023-10-05 上午10 21 37

I think it should be public

@kittybest

kittybest commented Oct 5, 2023

Copy link
Copy Markdown
Author

can it also solves popup to gist post? and the gist post is now secret 截圖 2023-10-05 上午10 21 37

I think it should be public

I think the popup to gist post works? oh but it's private so I need to make them public right? I think is the problem of the previous PR #99. I will edit there.

== UPDATED ==
I think it's default public, so no worry.

@ChialiT

ChialiT commented Oct 5, 2023

Copy link
Copy Markdown
Member

the popup for twitter doesn't work.
and it has weird behavior, when I clicked "post on twitter", UI show me the authorization, then UI bring me back to the "offline page" and then jump back to the simulator page.

and for the twitter text:

image

remove the "generate your verse...unirep protocol" from the text.
but leave that only to the meta description.

@kittybest

kittybest commented Oct 5, 2023

Copy link
Copy Markdown
Author

Problem found: gist will post without including contributionHashes since the ceremony is not loaded yet. Will fix it later.
(--> need to make sure the contributionHashes are really loaded before post.)

@kittybest

kittybest commented Oct 7, 2023

Copy link
Copy Markdown
Author
  • Fix the post on gist bug (= if post on gist without having access_token before, it will oauth first, and back to the page to post, but since the contributionHashes are not loaded yet, so the post only has introduction without hashes.)
    • might look like a dummy solution... but this is the safest way, I implement another solution in another branch, but still not perfect enough
  • I found the server will crash if twitter post return error messages, fixed. Need to re-deploy the backend
  • remove github name return on URL while coming back from oauth
  • Need to check if other oauth thing will cause server crash. --> but not in this PR, since it's a general problem we need to prevent, this PR might not be merged too if someone disagree to add this feature.

@ChialiT

ChialiT commented Oct 8, 2023

Copy link
Copy Markdown
Member

x popup works well on desktop, i think my desktop browser remember my twitter auth token.
on the mobile, user is require to login but I think its my browser issue.
but its works!

image there is very thin line on the right side of canvas, anyway we can get rid off?

@ChialiT

ChialiT commented Oct 8, 2023

Copy link
Copy Markdown
Member

there is few redirect ui under the overlay, I think its ok for now.

@vivianjeng
vivianjeng merged commit 1488abc into share-sns Oct 8, 2023
vivianjeng added a commit that referenced this pull request Oct 8, 2023
* add backend .env.example

* store github access_token in localstorage

* post on gist

* tweet a post (now the text is too long)

* update twitter post message

* chore: remove comments

* update node 16 to 18 in dockerfile

* add redirect_uri in env.example file, remove unused code

* change the tweet url to frontend url

* add og stuff in html

* add og xmlns in header

* modify contributionName to Anon/name chosen by user/github username/discord username

* store contributionName to localStorage

* update twitter post

* modify gist contribution text

* fix frontend bug

* fix twitter button bug after merge

* add popup box (#115)

* apply suggestion for text change

* chore(frontend): add og content and image (#127)

---------

Co-authored-by: Ya-wen, Jeng <vivi432@yahoo.com.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants