Skip to content

Contribute page - #90

Merged
CJ-Rose merged 7 commits into
stats-pagefrom
contribute-page
Aug 25, 2023
Merged

CJ-Rose merged 7 commits into
stats-pagefrom
contribute-page

Conversation

@kittybest

Copy link
Copy Markdown
  • re-styling contribute page according to Figma

@vercel

vercel Bot commented Aug 24, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trusted-setup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 0:26am

@kittybest
kittybest marked this pull request as ready for review August 25, 2023 12:01
@kittybest
kittybest requested a review from CJ-Rose August 25, 2023 12:01
@kittybest

kittybest commented Aug 25, 2023

Copy link
Copy Markdown
Author

Still some problems, but cannot be solved until the design is out.

  • frontend:
    • After clicking contribute, there should be some design and moving cosmo background, which is not finished yet. So I just put some text on the page.
    • Not removing commented code on Contribute Page: because they might be important after we apply cosmo canvas, so I keep them there to remind me some information.
    • I don't know if I need to implement the mobile version or not, since most of the designs are not ready
  • vercel: not sure why does it fail, I think we could merge this branch after the vercel error being fixed. --> update: I think it passed... and I don't know why, I just pushed a new commit 😅

@CJ-Rose CJ-Rose left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok yeah i think this is fine for now, i will merge both contribute-page and stats-page to base ui branch, we can revisit issues from there when the canvas creation is ready.

@CJ-Rose
CJ-Rose merged commit 85e15cc into stats-page Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants