fix: count reviewers who commented in assigned reviewers count - #56
Open
ptiper wants to merge 1 commit into
Open
fix: count reviewers who commented in assigned reviewers count#56ptiper wants to merge 1 commit into
ptiper wants to merge 1 commit into
Conversation
Include reviewers who submitted non-approving reviews (such as comments) in the assigned reviewers set so that the governance report accurately reflects active reviewers.
carolinerg1
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an assigned reviewer submits a comment review on GitHub, GitHub automatically fulfills their review request and removes them from the PR requested reviewers list (
pr.get_review_requests()). Becausepr_models.pyfilters out non-actionable review states likeCOMMENTEDfromlatest_actionable_reviews_by_username, these reviewers previously disappeared from theassignedlist entirely, causing the governance report to report0 eligible reviewers assignedeven when authorized reviewers were actively reviewing and commenting.This change includes non-author reviewers who have submitted reviews (such as comments) in the
assignedreviewer set (unless they have already approved), ensuring the governance validation report accurately reflects active reviewers inassigned_count.Category (Required)
Please select one or more categories that apply to this change.
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
None
Checklist
!for breaking changes).Screenshots / Logs (if applicable)