Skip to content

fix: count reviewers who commented in assigned reviewers count - #56

Open
ptiper wants to merge 1 commit into
Universal-Commerce-Protocol:mainfrom
ptiper:fix/governance-commented-assigned-count
Open

fix: count reviewers who commented in assigned reviewers count#56
ptiper wants to merge 1 commit into
Universal-Commerce-Protocol:mainfrom
ptiper:fix/governance-commented-assigned-count

Conversation

@ptiper

@ptiper ptiper commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Description

When an assigned reviewer submits a comment review on GitHub, GitHub automatically fulfills their review request and removes them from the PR requested reviewers list (pr.get_review_requests()). Because pr_models.py filters out non-actionable review states like COMMENTED from latest_actionable_reviews_by_username, these reviewers previously disappeared from the assigned list entirely, causing the governance report to report 0 eligible reviewers assigned even when authorized reviewers were actively reviewing and commenting.

This change includes non-author reviewers who have submitted reviews (such as comments) in the assigned reviewer set (unless they have already approved), ensuring the governance validation report accurately reflects active reviewers in assigned_count.

Category (Required)

Please select one or more categories that apply to this change.

  • Core Protocol: Changes to the base communication layer, global context, or breaking refactors. (Requires Technical Council approval)
  • Governance/Contributing: Updates to GOVERNANCE.md, CONTRIBUTING.md, or CODEOWNERS. (Requires Governance Council approval)
  • Capability: New schemas (Discovery, Cart, etc.) or extensions. (Requires Maintainer approval)
  • Documentation: Updates to README, or documentations regarding schema or capabilities. (Requires Maintainer approval)
  • Infrastructure: CI/CD, Linters, or build scripts. (Requires DevOps Maintainer approval)
  • Maintenance: Version bumps, lockfile updates, or minor bug fixes. (Requires DevOps Maintainer approval)
  • SDK: Language-specific SDK updates and releases. (Requires DevOps Maintainer approval)
  • Samples / Conformance: Maintaining samples and the conformance suite. (Requires Maintainer approval)
  • UCP Schema: Changes to the ucp-schema tool (resolver, linter, validator). (Requires Maintainer approval)
  • Community Health (.github): Updates to templates, workflows, or org-level configs. (Requires DevOps Maintainer approval)

Related Issues

None

Checklist

  • I have followed the Contributing Guide (including Conventional Commits title requirements and ! for breaking changes).
  • I have updated the documentation (if applicable).
  • My changes pass all local linting and formatting checks.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • (For Core/Capability) I have included/updated the relevant JSON schemas.
  • I have regenerated Python Pydantic models by running generate_models.sh under python_sdk.

Screenshots / Logs (if applicable)

============================== 61 passed in 0.15s ==============================

Include reviewers who submitted non-approving reviews (such as comments) in the assigned reviewers set so that the governance report accurately reflects active reviewers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants