chore: replace deprecated --allow-extra-fields codegen flag - #65
Open
XiaolongZhang-TT wants to merge 1 commit into
Open
Conversation
datamodel-code-generator deprecated --allow-extra-fields in favor of --extra-fields=allow: the CLI emits a DeprecationWarning on every generate_models.sh run, and the alias will be removed upstream (at which point generation breaks). Swap to the supported flag. Verified byte-identical codegen output between the two flags (diff -r over the full release/2026-04-08 schema set, same options otherwise), so the committed models are unchanged and the Universal-Commerce-Protocol#62 regeneration-equality check still passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
datamodel-code-generatordeprecated the--allow-extra-fieldsflag in favor of--extra-fields=allow.generate_models.shstill passes the deprecated alias, so every run emits:The alias will be removed upstream, at which point
generate_models.shbreaks outright. This swaps to the supported--extra-fields=allow.Verified byte-identical codegen output between the two flags —
diff -rover the fullrelease/2026-04-08schema set with all other options unchanged turned up no differences, so the committed models are untouched and the #62 regeneration-equality check still passes. Complements the generation-integrity work in #62.Category (Required)
Please select one or more categories that apply to this change.
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
None.
Checklist
!for breaking changes).Screenshots / Logs (if applicable)
The one-line change:
Equivalence check (full schema set, only the flag differing):