Fix calculation of COA times for bistatic images - #165
Merged
pressler-vsc merged 1 commit intoAug 28, 2026
Merged
Conversation
pressler-vsc
force-pushed
the
bistatic-coa-fix
branch
from
August 28, 2026 17:45
01ee539 to
2a22a3a
Compare
Contributor
|
Nice find; thanks for taking the time to track this down and open a PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SARkit was returning different
scene_to_image()results depending on the contents of the inputscene_pointsarray. If it contained one point, the returned image location was correct. If it contained a list of scene points, the returned image locations were slightly wrong. I tracked it back to the norm calculation incompute_coa_pos_vel().With the change, this simple test now passes: