Skip to content

Fix calculation of COA times for bistatic images - #165

Merged
pressler-vsc merged 1 commit into
ValkyrieSystems:bistatic-coa-fixfrom
Klamptoo:bistatic-coa-fix
Aug 28, 2026
Merged

pressler-vsc merged 1 commit into
ValkyrieSystems:bistatic-coa-fixfrom
Klamptoo:bistatic-coa-fix

Conversation

@Klamptoo

Copy link
Copy Markdown
Contributor

SARkit was returning different scene_to_image() results depending on the contents of the input scene_points array. If it contained one point, the returned image location was correct. If it contained a list of scene points, the returned image locations were slightly wrong. I tracked it back to the norm calculation in compute_coa_pos_vel().

With the change, this simple test now passes:

scene_coords = np.random.default_rng(789).uniform(low=-240.0, high=240.0, size=(7, 3)) + scp
assert(np.all(sksicd.scene_to_image(sicd_xmltree, scene_coords[0:1,:])[0][0] == sksicd.scene_to_image(sicd_xmltree, scene_coords)[0][0]))

@pressler-vsc
pressler-vsc changed the base branch from main to bistatic-coa-fix August 28, 2026 17:46
@pressler-vsc

Copy link
Copy Markdown
Contributor

Nice find; thanks for taking the time to track this down and open a PR

@pressler-vsc
pressler-vsc merged commit f7f6d68 into ValkyrieSystems:bistatic-coa-fix Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants