Skip to content

Make EResult (or the full response) accessible in SteamAuthenticatorError. #357

Description

@luckydonald

So current situation is that stuff like SteamAuthenticator(…).add() can cause SteamAuthenticatorError.

For example,

Traceback (most recent call last):
…
steam.guard.SteamAuthenticatorError: Failed to add authenticator. Error: <EResult.DuplicateRequest: 29>

Now that's a pretty easy to catch that error, telling the user to first have it log off the old instance, hence duplicate.
Just, we can't really distinguish those errors unless we do some ugly string stuff on that returned string.

# "Failed to add authenticator. Error: <EResult.DuplicateRequest: 29>"
if str(e).startswith("Failed to add authenticator. Error: <EResult."):
  error_string = str(e)[45:-1]  # "DuplicateRequest: 29"
  error_label, error_num = error_string.split(": ")
  from steam.enums import EResult
  error_label = EResult[error_label]
  error_num = EResult(int(error_num))
  if error_label == error_num:
    error = error_label
  # end if
  if error == EResult.DuplicateRequest:
    exit('Already have set an authenticator in another app')
  # end if
# end if

This is obviously super prone to issues due to changes there, it would be way better to just include those fields in the exception.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions