Guard sidebar widget container index#8307
Draft
plafosse wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
SidebarWidgetContainer::m_widgetsleaf values from rawSidebarWidgetAndHeader*toQPointer<SidebarWidgetAndHeader>so the sidebar context index observes Qt-owned widgets safely.Why
The E9 crash path points at stale sidebar widget/header pointers during view-change fan-out. The container index is not the owner; Qt parentage and the stacked widget hierarchy own these widgets. Using
QPointermakes stale observer entries become null when Qt destroys the object.Validation
git -C api diff --checkcmake --build /private/tmp/bn-e9-build-demo --target binaryninjaui -j 8Companion parent repo PR will update the submodule pointer and implementation.