Settle by value - #1937
Merged
Merged
Settle by value#1937
Conversation
A passing inline verification now sends the value its expected argument holds with its settle, and passes it to InlineStaging.Clear (DiffEngine 20.5.0). Where the line names no entry, the queue owner falls back to the member, and a member is not a call site: a member holding one pending entry gave it up to whichever of its calls passed, so the passing sibling of a failing call settled the failing one's entry, and on disk deleted its staged trio. That snapshot was then pending nowhere. With the value, only an entry the value settles is taken: one anchored to it, or waiting to become it. A retire still sends no value, having no inline snapshot to settle by. Needs DiffEngine 20.5.0, which is not published yet.
This was referenced Sep 23, 2026
Merged
Merged
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.