fix: add inverse crosshair when set axes inverse - #3989
Conversation
|
@xuanhun 辛苦抽空帮忙 review 下这个 PR。 |
|
@xuefei1313 请问这个 PR 还能继续推进吗,很久之前提出的了,没人帮忙处理。 |
@xuefei1313 Can this PR be pushed forward? It was raised a long time ago and no one has helped. |
Thank you for submitting fixes, providing verification screenshots, and continuing to follow up, and I'm sorry for making this PR wait so long. In this review, we confirmed that #4561 can simultaneously cover the histogram and mosaic scenes under the reverse coordinate axis by uniformly calculating the starting point and width of the crosshair based on the two endpoints of the interval. During the evaluation, we also additionally verified that the combination of the horizontal and vertical axes, forward and reverse directions, and field order covered the issues corresponding to this PR. In order to centralize review and maintenance, the follow-up will be unified by #4561, so this PR is closed. #4561 has not yet been merged, and the related issue #3973 still needs to be fixed through subsequent merges. Thank you for your contribution to problem location, fix and verification! |

🤔 这个分支是...
🔗 相关 issue 链接
Fixed #3973
🔗 相关的 PR 链接
None
🐞 Bugserver 用例 id
Badcase:
💡 问题的背景&解决方案
直方图 axes 设置反向后, 由于 bandSize 设置了 Math.abs 导致 crossHair 没有正确渲染。对
axis.getInverse() && axis.type === ComponentTypeEnum.cartesianLinearAxis进行反向处理。📝 Changelog
☑️ 自测
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough