Skip to content

test: add dual axis chart spec coverage - #296

Closed
cat0825 wants to merge 1 commit into
VisActor:mainfrom
cat0825:test/get-chart-spec-dual-axis
Closed

test: add dual axis chart spec coverage#296
cat0825 wants to merge 1 commit into
VisActor:mainfrom
cat0825:test/get-chart-spec-dual-axis

Conversation

@cat0825

@cat0825 cat0825 commented May 30, 2026

Copy link
Copy Markdown

What type of PR is this?

  • test

What this PR does / why we need it

Adds unit coverage for getChartSpecWithContext when chartType is Dual Axis Chart.

The new test verifies that VMind's chart spec pipeline returns the expected VChart common spec, including the bar/line series, dual-axis field mapping, generated data values, and axis configuration.

Fixes #222

Which issue(s) this PR fixes

Fixes #222

Special notes for your reviewer

Validation run locally with Node 18.20.8:

  • npx --yes node@18 ../../common/scripts/install-run-rush.js install
  • npx --yes node@18 ../../common/scripts/install-run-rushx.js test -- --runTestsByPath __tests__/unit/getChartSpecWithContext_dualAxis.test.ts

I also ran npx --yes node@18 ../../common/scripts/install-run-rushx.js compile; it fails on pre-existing workspace type-resolution/type errors unrelated to this test-only change, mostly unresolved workspace package types such as @visactor/generate-vchart and @visactor/chart-advisor.

@github-actions github-actions Bot added the vmind label May 30, 2026
@cat0825
cat0825 force-pushed the test/get-chart-spec-dual-axis branch from 9ce01f5 to 72c32ec Compare May 30, 2026 13:04
@cat0825

cat0825 commented Jul 11, 2026

Copy link
Copy Markdown
Author

Friendly follow-up on this dual-axis unit coverage. Related chart-type coverage for linear progress is in #297. Happy to adjust assertions if the expected common series shape has drifted.

1 similar comment
@cat0825

cat0825 commented Jul 11, 2026

Copy link
Copy Markdown
Author

Friendly follow-up on this dual-axis unit coverage. Related chart-type coverage for linear progress is in #297. Happy to adjust assertions if the expected common series shape has drifted.

@cat0825

cat0825 commented Aug 29, 2026

Copy link
Copy Markdown
Author

Closing this from my side. The repository has had no commits since 2025-12-16 and no merged PRs since then, and this PR (plus #297 and #298) has been BLOCKED on maintainer approval for ~7 weeks with green CI, so there is no path to landing it right now.

Nothing is wrong with the coverage itself — the branch stays on my fork. If VMind maintenance resumes and you want the dual-axis / linear-progress / funnel spec coverage, reopen or ping me and I will rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant