Add CSV and SQLite viewers with XLSX export support - #15
Conversation
✅ Deploy Preview for lexispredict ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Strix is installed on this repository, but we couldn't run this PR security review because this workspace's trial has ended. Add a card to resume code reviews here. |
There was a problem hiding this comment.
Graphify reviewed this change.
Worth a look — the grounded gate found no coupling regressions or blocking issues, but 3 advisory finding(s) below merit a look before merge.
Graphify review — findings
Streams XLSX export from the local SQLite viewer in 10k-row query chunks (yielding to the event loop between batches) instead of loading every row at once, so large tables export without blocking the UI. Adds a row-count control letting the user pick how many rows to export or select "all", caps the total at XLSX_MAX_ROWS, and names the download <table>-<n>-linhas.xlsx. Updates the file-size guidance copy to mention the SQLite WASM in-memory limit.
Worth a look
- Concurrent file opens can publish a stale database and leak the newer one —
src/components/db/local-db-viewer.tsx:43· Escalate · medium- agreed by 2 of 2 members but NOT verified (no proof, no reproducing execution) — consensus is not a verdict; needs human review
- exportXlsx reads database/current/exportRows without re-checking after await, allowing stale/closed state —
src/components/db/local-db-viewer.tsx:82· Escalate · medium- agreed by 2 of 2 members but NOT verified (no proof, no reproducing execution) — consensus is not a verdict; needs human review
- Default XLSX export now truncates to 100 rows —
src/components/db/local-db-viewer.tsx:83· Escalate · medium- agreed by 2 of 2 members but NOT verified (no proof, no reproducing execution) — consensus is not a verdict; needs human review
Analysis details — impact, health, verification
Impact & health
Graphify review
Impact — 7 functions depend on the 7 functions this change touches.
Health — grade A; no new coupling hotspots.
Verification — 7 functions in the blast radius were not formally verified this run (proofs are advisory here).
Gate & verification
graphify gate
PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.
Advisory (not blocking):
- verification_scope: 7 function(s) in the blast radius were not formally verified this run
v0 Session