support adcmod sibling directories#2
Open
joefutrelle wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for preferring corrected ADC files (.adc.mod) located in an adcmod directory when resolving fileset paths, across both synchronous and asynchronous directory APIs.
Changes:
- Introduces shared sync/async ADC path resolution helpers that search for
.adc.modcandidates and fall back to the raw.adc. - Updates
SyncIfcbDataDirectoryandAsyncIfcbDataDirectorypaths()andlist()to use the new resolution logic. - Adds a dedicated test suite validating
.adc.modpreference behavior, including an end-to-end I-style bin read-path check.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/ifcbkit/fileset.py | Adds adcmod-aware ADC resolution helpers and wires them into sync/async directory paths()/list() outputs. |
| tests/test_fileset.py | Adds coverage for adcmod resolution scenarios and end-to-end validation that corrected ADC content is used. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
johnwaalsh
reviewed
Jul 16, 2026
Collaborator
Author
|
@johnwaalsh I found a problem with behavior and fixed it so requesting another look. |
johnwaalsh
approved these changes
Jul 16, 2026
johnwaalsh
left a comment
Member
There was a problem hiding this comment.
That behavior change makes sense to me. Good to avoid checking paths that we don't need to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for using corrected ADC files (with the
.adc.modextension) from a siblingadcmoddirectory, preferring them over raw.adcfiles when available. It updates both synchronous and asynchronous code paths to resolve the appropriate ADC file and includes comprehensive tests for this new behavior.ADC file resolution enhancements:
.adc.mod) in anadcmodsibling directory, falling back to the raw.adcif none is found. This is implemented in the new_sync_resolve_adc_pathand_async_resolve_adc_pathfunctions, which are used throughout the codebase for both synchronous and asynchronous file resolution.pathsandlistmethods in bothSyncIfcbDataDirectoryandAsyncIfcbDataDirectoryto use the new resolution logic, ensuring that the returned ADC path points to the corrected file if it exists. [1] [2] [3] [4]Testing improvements:
tests/test_fileset.py) that covers various scenarios for ADC file resolution, including presence/absence ofadcmodfiles, directory structures, and end-to-end validation that corrected ADC files are actually used in downstream processing.