fix(companion-wallet): reject path-like session IDs - #58
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
grantSession emits 32 hex chars. loadSession joined any sessionId onto the sessions dir, so get-session ../keys/<address> read a keystore JSON (including the mnemonic). Keep session files under the sessions directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grantSessionemits a 32-char hex id.loadSession/get-sessionjoined anysessionIdonto~/.config/wallet/sessions.filepath-style..(for example../keys/<address>) opened a sibling keystore JSON, including the mnemonic.sessionFilePathnow requires^[0-9a-f]{32}$before join, matching the idsgrantSessionalready issues. Granted sessions still load.Why
An agent or CWP caller already chooses
sessionId. They do not already have read of~/.config/wallet/keys. The remaining guard is that session files stay under the sessions directory.Test plan
npm test --workspace=@walletconnect/companion-wallet(108/108 after workspace build)npm run lint --workspace=@walletconnect/companion-walletloadSession("../keys/0xdead")returns the sibling keystore instead of throwing