remove require('process') - #2
Open
max-mapper wants to merge 1 commit into
Open
Conversation
Contributor
|
I think I was using this so I could disable globals detection to speed things up. Is that not an issue any more with the new parsing/ast infrastructure? |
Author
|
not sure, I just get this error when I try to use newer browserify: |
Contributor
|
oops but that's a browserify bug isn't it? Unfortuantely I don't have write access to this repo any more, anyone? |
|
nowpe. |
Author
|
I assumed it was removed from browserify on purpose. Either way this pr On Tuesday, March 11, 2014, Paolo Fragomeni notifications@github.com
|
|
Same problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
via https://github.com/substack/node-browserify#compatibility this isn't required anymore