Make SpeechGrammarList.item() nullable. - #212
Merged
Merged
Conversation
Member
Author
hoch
reviewed
Sep 8, 2026
The return type was non-nullable, so an index greater than or equal to length had no valid return value. Chromium declares it non-nullable too, but its implementation returns null for such an index, and other platform collections with an item() getter (NodeList, HTMLCollection, CSSRuleList, FileList) all declare it nullable, so specify null and match what ships.
padenot
force-pushed
the
nullable-grammar-item
branch
from
September 8, 2026 16:48
17decaa to
3f9e1f4
Compare
github-actions Bot
added a commit
that referenced
this pull request
Sep 9, 2026
SHA: 291cb48 Reason: push, by padenot Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Sep 9, 2026
…dex is out of range. r=media-playback-reviewers,webidl,smaug,alwu item() indexed straight into the array, so an out-of-range index crashed. Blink's item() returns nullptr there and its bindings hand that to JS as null, so make the WebIDL return type nullable and do the same. WebAudio/web-speech-api#212 aligns the spec. Differential Revision: https://phabricator.services.mozilla.com/D324284
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 10, 2026
…range. item() indexed straight into the array, so an out-of-range index crashed. Blink's item() returns nullptr there and its bindings hand that to JS as null, so make the WebIDL return type nullable and do the same. WebAudio/web-speech-api#212 aligns the spec. Differential Revision: https://phabricator.services.mozilla.com/D324284 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2068066 gecko-commit: 7345f092b989ee703ac09898eb0ae04ee434a111 gecko-commit-git: 15e65f9002f4193a1eff321726ff8983d413f829 gecko-reviewers: media-playback-reviewers, webidl, smaug, alwu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return type was non-nullable, so an index greater than or equal to length had no valid return value. Chromium declares it non-nullable too, but its implementation returns null for such an index, and other platform collections with an item() getter (NodeList, HTMLCollection, CSSRuleList, FileList) all declare it nullable, so specify null and match what ships.
I'm sending a Gecko patch that includes a WPT for this.
Preview | Diff