Extract duplicated cleanup_test_files function to shared test utility module

[coderabbitai]

Summary

The cleanup_test_files function is duplicated across multiple test files in the file I/O test suite.

Affected Files

The same helper function appears in:

• tests/file_io_execution_test.rs (lines 12-16)
• tests/file_io_error_handling_test.rs (lines 12-16)
• tests/file_io_performance_test.rs (lines 14-18)
• tests/file_io_concurrent_test.rs (lines 13-17)

Proposed Solution

Extract the function to a shared test utilities module:

1. Create tests/common.rs with a public cleanup_test_files(files: &[&str]) function
2. Remove the local function from each test file
3. Add module import (e.g., mod common; or #[path = "common.rs"] mod common;) to each test file
4. Update calls to use common::cleanup_test_files(...)

Benefits

• Reduces code duplication
• Centralizes test utility functions
• Makes maintenance easier

Backlinks

• Original PR: Enhances file I/O & adds security policy #150
• Discussion: Enhances file I/O & adds security policy #150 (comment)

Requested by: @logbie

[logbie]

@claude investigate this issue and fix if necessary

[claude]

Claude finished @logbie's task —— View job

---

Analysis Complete

After thoroughly investigating this issue, I can confirm that the problem described does not exist in the current codebase.

Investigation Results

Files mentioned in the issue:

• tests/file_io_execution_test.rs - ❌ Does not exist
• tests/file_io_error_handling_test.rs - ❌ Does not exist
• tests/file_io_performance_test.rs - ❌ Does not exist
• tests/file_io_concurrent_test.rs - ❌ Does not exist

Function mentioned:

• cleanup_test_files - ❌ Not found anywhere in the codebase

Current test structure:

• Only 3 test files exist in /tests/:
  • colon_consumption_test.rs
  • container_ast_corruption_test.rs
  • container_parsing_fixes.rs
• File I/O tests are properly organized in src/interpreter/io_tests.rs
• No code duplication found in existing test infrastructure

PR #150 Reference:

• No evidence of PR Enhances file I/O & adds security policy #150 exists in git history, documentation, or codebase
• No references to this PR found in development notes or plans

Current File I/O Test Infrastructure

The project has a well-organized, non-duplicated file I/O test infrastructure:

Location: src/interpreter/io_tests.rs
Tests include:

• Basic file I/O operations
• Write/read cycles
• Error handling
• Resource cleanup (test_file_handle_cleanup)
• HTTP operations
• Try/when error handling

Integration tests: TestPrograms/file_io_comprehensive.wfl

Conclusion

This issue can be closed as invalid/not applicable. The code duplication problem it aims to solve does not exist in the current codebase. The file I/O test infrastructure is already properly organized without duplication.

Recommendation: Consider closing this issue as the referenced files and duplication do not exist. If there are plans to create these test files in the future, the issue could be repurposed to track the creation of proper shared test utilities from the start.