Skip to content

fix: pass loaded WflConfig to Interpreter (not just timeout) #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
logbie wants to merge 1 commit into from
Closed

fix: pass loaded WflConfig to Interpreter (not just timeout) #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1180,7 +1180,7 @@ async fn main() -> io::Result<()> {
// Log execution start if execution logging is enabled
exec_trace!("Starting execution of script: {}", &file_path);

let mut interpreter = Interpreter::with_timeout(config.timeout_seconds);
let mut interpreter = Interpreter::with_config(std::sync::Arc::new(config.clone()));

Copilot AI Apr 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching from Interpreter::with_timeout(...) to Interpreter::with_config(...) changes timeout semantics: with_timeout clamps the timeout to a max of 300s, but with_config uses config.timeout_seconds as-is. If the 300s cap is intentional (e.g., to prevent extremely long-running scripts), consider preserving it here by clamping config.timeout_seconds before constructing the interpreter or by moving the cap into config loading/validation so both constructors behave consistently.

Suggested change
let mut interpreter = Interpreter::with_config(std::sync::Arc::new(config.clone()));
let mut interpreter_config = config.clone();
interpreter_config.timeout_seconds = interpreter_config.timeout_seconds.min(300);
let mut interpreter =
Interpreter::with_config(std::sync::Arc::new(interpreter_config));

Copilot uses AI. Check for mistakes.
interpreter.set_step_mode(step_mode); // Set step mode from CLI flag
interpreter.set_test_mode(test_mode); // Set test mode from CLI flag
interpreter.set_script_args(script_args); // Pass script arguments
Expand Down
Loading