Skip to content

fix(ci): raise nightly Windows build timeout 60→90 min (nightly timed out 2026-07-15) - #618

Merged
logbie merged 2 commits into
mainfrom
warden/fix-nightly-windows-timeout
Jul 15, 2026
Merged

fix(ci): raise nightly Windows build timeout 60→90 min (nightly timed out 2026-07-15)#618
logbie merged 2 commits into
mainfrom
warden/fix-nightly-windows-timeout

Conversation

@logbie

@logbie logbie commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

What was broken

The scheduled Nightly Build on 2026-07-15 (run 29392474402) did not publish a nightly release. The Build WFL for Windows job ran for 60m07s (05:50:00Z → 06:50:07Z) and was cancelled by its timeout-minutes: 60 cap; the Create or Update Nightly Release job was then skipped. So main @56b5adb has no nightly artifact.

Root cause

Not a code or packaging fault — a chronic thin-margin timeout. The Windows build legitimately takes close to an hour and the durations of the last five successful nightlies sit right against the cap:

Nightly Build duration
2026-07-10 51.0 min
2026-07-11 58.7 min
2026-07-12 54.7 min
2026-07-13 57.5 min
2026-07-14 56.1 min
2026-07-15 60.1 min → cancelled (timeout)

With ~9 minutes of run-to-run variance and a 60-minute ceiling, any slightly slower runner (or incremental codebase growth) tips the job over. This exact margin was flagged as a watch item in prior maintenance passes ("59m22s, watch the margin"). Today it crossed the line.

The fix

Raise timeout-minutes on the Build WFL for Windows job from 60 → 90, restoring ~30 minutes of headroom over the typical ~57-minute build. One line, CI-only:

     runs-on: windows-latest
-    timeout-minutes: 60
+    timeout-minutes: 90

No build steps, dependencies, or product behavior are changed; the release job's own 15-minute timeout is untouched. This does not mask a hang — the job was making normal progress and finished each recent run in ~51–59 minutes; it simply needs a realistic ceiling. (A separate, larger effort to actually shorten the Windows build — e.g. caching/packaging tuning — would be worthwhile but is out of scope for restoring green tonight.)

Verification

  • Confirmed the cancellation was the 60-minute cap: the job's own runtime was exactly 60m07s and the release job shows skipped, not a step failure.
  • nightly.yml parses cleanly (yaml.safe_load).
  • The Windows-only nightly path cannot be reproduced on Linux (per the repo's CI failure map §F); the next scheduled nightly on main — or a manual workflow_dispatch from main after merge — will confirm the build now completes and publishes. I deliberately did not trigger a workflow_dispatch from this branch: the release job is gated only on should_build, not on main, so a branch run would tag and publish a nightly release from a non-main commit.

Automated triage PR from the WFL repo warden — opened for a human to review and merge; the warden does not self-merge.


Open in Devin Review

Summary by CodeRabbit

  • Chores
    • Increased the Windows nightly build timeout to 90 minutes, reducing cancellations during longer-running builds.

The 'Build WFL for Windows' job hit its 60-minute timeout on the
2026-07-15 nightly (run 29392474402, 60m07s -> cancelled), so no
nightly release was published for main @56b5adb. Recent build durations
(51.0, 58.7, 54.7, 57.5, 56.1 min) sit right against the 60-minute cap,
leaving effectively no margin for runner-speed variance. Raise the cap
to 90 minutes to restore headroom. CI-only change; no build behavior
is altered.
Copilot AI review requested due to automatic review settings July 15, 2026 09:06
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0f9fcf85-39dc-4260-9eb8-6cde5f562133

📥 Commits

Reviewing files that changed from the base of the PR and between 56b5adb and 0329d07.

📒 Files selected for processing (1)
  • .github/workflows/nightly.yml

📝 Walkthrough

Walkthrough

The nightly workflow’s Windows build job timeout is increased from 60 to 90 minutes.

Changes

Nightly build timeout

Layer / File(s) Summary
Windows build timeout
.github/workflows/nightly.yml
The Windows build job’s timeout-minutes value changes from 60 to 90.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: increasing the nightly Windows build timeout from 60 to 90 minutes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch warden/fix-nightly-windows-timeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Windows nightly CI workflow to prevent scheduled nightlies from being cancelled due to an overly tight job timeout, ensuring nightly artifacts are produced reliably.

Changes:

  • Increased the Build WFL for Windows job timeout from 60 minutes to 90 minutes in the nightly GitHub Actions workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings July 15, 2026 16:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@logbie
logbie merged commit 6c9888c into main Jul 15, 2026
16 of 17 checks passed
@logbie
logbie deleted the warden/fix-nightly-windows-timeout branch July 15, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants