fix(ci): raise nightly Windows build timeout 60→90 min (nightly timed out 2026-07-15) - #618
Conversation
The 'Build WFL for Windows' job hit its 60-minute timeout on the 2026-07-15 nightly (run 29392474402, 60m07s -> cancelled), so no nightly release was published for main @56b5adb. Recent build durations (51.0, 58.7, 54.7, 57.5, 56.1 min) sit right against the 60-minute cap, leaving effectively no margin for runner-speed variance. Raise the cap to 90 minutes to restore headroom. CI-only change; no build behavior is altered.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe nightly workflow’s Windows ChangesNightly build timeout
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Windows nightly CI workflow to prevent scheduled nightlies from being cancelled due to an overly tight job timeout, ensuring nightly artifacts are produced reliably.
Changes:
- Increased the
Build WFL for Windowsjob timeout from 60 minutes to 90 minutes in the nightly GitHub Actions workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What was broken
The scheduled Nightly Build on 2026-07-15 (run 29392474402) did not publish a nightly release. The
Build WFL for Windowsjob ran for 60m07s (05:50:00Z → 06:50:07Z) and was cancelled by itstimeout-minutes: 60cap; theCreate or Update Nightly Releasejob was then skipped. Somain@56b5adbhas no nightly artifact.Root cause
Not a code or packaging fault — a chronic thin-margin timeout. The Windows build legitimately takes close to an hour and the durations of the last five successful nightlies sit right against the cap:
With ~9 minutes of run-to-run variance and a 60-minute ceiling, any slightly slower runner (or incremental codebase growth) tips the job over. This exact margin was flagged as a watch item in prior maintenance passes ("59m22s, watch the margin"). Today it crossed the line.
The fix
Raise
timeout-minuteson theBuild WFL for Windowsjob from 60 → 90, restoring ~30 minutes of headroom over the typical ~57-minute build. One line, CI-only:No build steps, dependencies, or product behavior are changed; the release job's own 15-minute timeout is untouched. This does not mask a hang — the job was making normal progress and finished each recent run in ~51–59 minutes; it simply needs a realistic ceiling. (A separate, larger effort to actually shorten the Windows build — e.g. caching/packaging tuning — would be worthwhile but is out of scope for restoring green tonight.)
Verification
skipped, not a step failure.nightly.ymlparses cleanly (yaml.safe_load).main— or a manualworkflow_dispatchfrommainafter merge — will confirm the build now completes and publishes. I deliberately did not trigger aworkflow_dispatchfrom this branch: thereleasejob is gated only onshould_build, not onmain, so a branch run would tag and publish a nightly release from a non-maincommit.Automated triage PR from the WFL repo warden — opened for a human to review and merge; the warden does not self-merge.
Summary by CodeRabbit