Skip to content

fix(ci): raise Build/Test/Clippy timeout from 15 to 30 minutes - #619

Merged
logbie merged 1 commit into
mainfrom
claude/github-failures-diagnosis-ty0j1b
Jul 16, 2026
Merged

fix(ci): raise Build/Test/Clippy timeout from 15 to 30 minutes#619
logbie merged 1 commit into
mainfrom
claude/github-failures-diagnosis-ty0j1b

Conversation

@logbie

@logbie logbie commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

The clippy-and-test job compiles the workspace three times (debug,
release, and a third release build for the panic=abort assert), runs the
full workspace test suite, builds the LSP binary, and runs Clippy. That
real work now lands right at ~15 minutes even with a warm cache.

As a result, the last two pushes to main both failed CI: the 15-minute
timeout-minutes fired mid-Clippy (run 1a9705a) or during the cache-save
Post step (run 6c9888c), marking the whole job cancelled even though
every real step passed. A cancelled job also skips bump-version, so
post-merge version bumps stopped happening.

Raise the limit to 30 minutes to give headroom for cold-cache builds
while still bounding a genuinely hung job.

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_015fZVmhdQkqK15wvKjzeRYS

Summary by CodeRabbit

  • Chores
    • Increased the CI validation time limit to better support slower, cold-cache builds.
    • Added explanatory notes about timeout behavior and version update handling.

The `clippy-and-test` job compiles the workspace three times (debug,
release, and a third release build for the panic=abort assert), runs the
full workspace test suite, builds the LSP binary, and runs Clippy. That
real work now lands right at ~15 minutes even with a warm cache.

As a result, the last two pushes to main both failed CI: the 15-minute
`timeout-minutes` fired mid-Clippy (run 1a9705a) or during the cache-save
Post step (run 6c9888c), marking the whole job `cancelled` even though
every real step passed. A cancelled job also skips `bump-version`, so
post-merge version bumps stopped happening.

Raise the limit to 30 minutes to give headroom for cold-cache builds
while still bounding a genuinely hung job.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015fZVmhdQkqK15wvKjzeRYS
Copilot AI review requested due to automatic review settings July 16, 2026 06:41
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ccb87c44-d223-4981-939f-34d8f38c0b7b

📥 Commits

Reviewing files that changed from the base of the PR and between 6c9888c and 6a2991e.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The CI clippy-and-test job timeout increases from 15 to 30 minutes, with comments documenting prior timeout points and the rationale for additional cold-cache build headroom.

Changes

CI timeout adjustment

Layer / File(s) Summary
Clippy and test timeout update
.github/workflows/ci.yml
The clippy-and-test job timeout increases to 30 minutes, with comments describing Clippy, cache-save, and version-bump behavior.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the CI timeout increase from 15 to 30 minutes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/github-failures-diagnosis-ty0j1b

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR increases the GitHub Actions CI job timeout for the clippy-and-test workflow job to prevent spurious cancellations during long builds/tests/Clippy runs, which can also block downstream jobs like version bumping.

Changes:

  • Increased clippy-and-test job timeout-minutes from 15 to 30.
  • Added inline rationale explaining why the extra headroom is needed (warm vs cold cache, cancellation side effects).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@logbie
logbie merged commit c4851c3 into main Jul 16, 2026
17 checks passed
@logbie
logbie deleted the claude/github-failures-diagnosis-ty0j1b branch July 16, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants