fix(ci): raise Build/Test/Clippy timeout from 15 to 30 minutes - #619
Conversation
The `clippy-and-test` job compiles the workspace three times (debug, release, and a third release build for the panic=abort assert), runs the full workspace test suite, builds the LSP binary, and runs Clippy. That real work now lands right at ~15 minutes even with a warm cache. As a result, the last two pushes to main both failed CI: the 15-minute `timeout-minutes` fired mid-Clippy (run 1a9705a) or during the cache-save Post step (run 6c9888c), marking the whole job `cancelled` even though every real step passed. A cancelled job also skips `bump-version`, so post-merge version bumps stopped happening. Raise the limit to 30 minutes to give headroom for cold-cache builds while still bounding a genuinely hung job. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015fZVmhdQkqK15wvKjzeRYS
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI ChangesCI timeout adjustment
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR increases the GitHub Actions CI job timeout for the clippy-and-test workflow job to prevent spurious cancellations during long builds/tests/Clippy runs, which can also block downstream jobs like version bumping.
Changes:
- Increased
clippy-and-testjobtimeout-minutesfrom 15 to 30. - Added inline rationale explaining why the extra headroom is needed (warm vs cold cache, cancellation side effects).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The
clippy-and-testjob compiles the workspace three times (debug,release, and a third release build for the panic=abort assert), runs the
full workspace test suite, builds the LSP binary, and runs Clippy. That
real work now lands right at ~15 minutes even with a warm cache.
As a result, the last two pushes to main both failed CI: the 15-minute
timeout-minutesfired mid-Clippy (run 1a9705a) or during the cache-savePost step (run 6c9888c), marking the whole job
cancelledeven thoughevery real step passed. A cancelled job also skips
bump-version, sopost-merge version bumps stopped happening.
Raise the limit to 30 minutes to give headroom for cold-cache builds
while still bounding a genuinely hung job.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_015fZVmhdQkqK15wvKjzeRYS
Summary by CodeRabbit