Give the fork's identity tests the suite's connection timeout - #83
Merged
Merged
Conversation
The two useAgent identity tests the fork added in db417b5 wait for a fresh agent's identity callback with vi.waitFor's default one-second window. Every other connection wait in rpc-robustness.test.tsx passes { timeout: 10000 }. On a cold CI runner the first connection to a new Durable Object took longer than a second, so "starts identity comparison over when the requested address changes" failed on main right after the 0.9.0 release merge with zero calls recorded. Give its four waits the same ten seconds as the rest of the file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on main failed right after the 0.9.0 release merge (#78). This fixes the flaky test. The npm publish itself succeeded.
Cause. "starts identity comparison over when the requested address changes" is one of two
useAgentidentity tests the fork added in db417b5. Both wait for a fresh agent's identity callback withvi.waitFor's default one-second window. On a cold runner the first connection to a new Durable Object took longer than that, so the wait ended with zero calls recorded. Every other connection wait inrpc-robustness.test.tsxalready passes a ten-second timeout.Fix. Give the four waits in those two tests the same
{ timeout: 10000 }as the rest of the file. Test-only, so no changeset and no fork-diff row change.Check. The file passes 16 of 16 locally in Chromium. The failure is timing-only, so I did not build a deterministic reproduction.
🤖 Generated with Claude Code