Skip to content

Morning session P2P Coding review 28/09/2021 #7

Description

@lfmnovaes

Great job on your project Alex 🙌

I really liked the way you placed the call for each event on your code. 👍

I've just noticed one small thing that might make your code run faster:

  • You should consider removing the sort function calls and instead replace the index attribute of each element with the actual position it is in the array. Your orderArray function:
    elementArray.sort((a, b) => ((a.index > b.index) ? 1 : -1));

Other than that your project looks amazing, keep the good work 😃

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions