[FIX] PR #139: missing @WHO headers on formatter files + wrong command count in docs

[Wolfvin]

Context

PR #139 (feat(formatters): unified Finding dataclass + 5 new formatters — closes #52) needs two fixes before it can be merged.

Issues Found

1. Missing file headers on new formatter files

The following new files are missing required @WHO/@WHAT/@PART/@ENTRY headers:

• scripts/formatters/text.py
• scripts/formatters/vim.py
• scripts/formatters/emacs.py
• scripts/formatters/junit_xml.py
• scripts/formatters/gitlab_sast.py

Add the standard header to each file. Example:

# @WHO:   scripts/formatters/junit_xml.py
# @WHAT:  JUnit XML formatter for CI test report integration
# @PART:  formatters
# @ENTRY: format_findings()

2. Wrong command count in docs

PR #139 bumped docs to 69 CLI commands / 67 MCP tools — but this PR adds 0 new commands and 0 new MCP tools (only internal formatters, no new registry entries). The count should remain unchanged.

Fix: run python3 scripts/sync_command_count.py --apply and verify the count it produces matches what's in README.md, SKILL.md, SKILL-QUICK.md, pyproject.toml, skill.json. Commit the corrected counts.

Definition of Done

• All 5 formatter files have correct @WHO/@WHAT/@PART/@ENTRY headers
• sync_command_count.py --apply run and count matches current main (check main first with python3 scripts/sync_command_count.py)
• PR feat(formatters): unified Finding dataclass + 5 new formatters — text, junit-xml, emacs, vim, gitlab-sast (closes #52) #139 rebased on main after these fixes are committed to its branch
• PR feat(formatters): unified Finding dataclass + 5 new formatters — text, junit-xml, emacs, vim, gitlab-sast (closes #52) #139 is mergeable (no conflicts)

[Wolfvin]

🔄 Taking this issue

Mengerjakan issue ini -- 2026-07-03T02:56:04Z

Identity: Executor·Pragmatist

Scope: full issue — add @WHO/@WHAT/@PART/@entry headers to 5 formatter files (text.py, vim.py, emacs.py, junit_xml.py, gitlab_sast.py) di branch PR #139, run sync_command_count.py --apply untuk fix wrong command count, rebase PR #139 on main, verify mergeable.

[Wolfvin]

PR siap review

PR: #139 — feat(formatters): unified Finding dataclass + 5 new formatters — text, junit-xml, emacs, vim, gitlab-sast (closes #52)
Branch: feat/issue-52-formatters-expansion
Summary: Issue #170 fixes applied to PR #139. (1) Added @WHO/@WHAT/@PART/@entry headers to 5 new formatter files (text.py, vim.py, emacs.py, junit_xml.py, gitlab_sast.py). (2) Fixed wrong command count by rebasing PR #139 on latest main — the rebase took main's version of all 6 doc files since PR #139's only doc changes were the incorrect count bump (68→69 when 0 commands were added). After rebase, sync_command_count.py --check is clean (75 commands, matching main). PR #139 is now mergeable (no conflicts).
Tests: 85 passed in test_formatters_base.py + test_formatters_phase2.py + test_command_count.py. 1 deselected (test_help_lists_new_formats) — fails due to pre-existing argparse -f conflict on main, NOT a regression from this PR. Verified the same test failures exist on origin/main.

Rebase conflicts resolved:

• scripts/codelens.py: merged main's 'graphml' format choice + PR feat(formatters): unified Finding dataclass + 5 new formatters — text, junit-xml, emacs, vim, gitlab-sast (closes #52) #139's 5 new format choices into one add_argument() call
• scripts/formatters/init.py: merged main's graphml dispatch block + PR feat(formatters): unified Finding dataclass + 5 new formatters — text, junit-xml, emacs, vim, gitlab-sast (closes #52) #139's 5 new format dispatch blocks into format_output()
• 6 doc files (README, SKILL, SKILL-QUICK, pyproject, skill.json, graph_model.py): took main's version (PR feat(formatters): unified Finding dataclass + 5 new formatters — text, junit-xml, emacs, vim, gitlab-sast (closes #52) #139's count bump was wrong)

Findings (di luar scope, di main juga):

• argparse.ArgumentError: conflicting option string: -f. Main's codelens.py adds --format/-f both at subparser level (line 892) AND at global parser level (line 926, introduced by PR [FEAT] --diff-base flag: scope all analysis commands to changed files only #157 --diff-base). Any CLI invocation crashes. Pre-existing bug on main, NOT a regression. Affects test_cli.py + test_doctor.py CLI smoke tests too. Suggest separate issue to fix.