fix(regret.js): honest deprecation message for 'regret ci' — acknowledge kotlin/zig limitation (#549) - #554
Merged
Merged
Conversation
…dge kotlin/zig limitation (#549) Red team R-2 found that 'regret ci' deprecation message claimed 'functionally identical to regret validate --fail-fast', but for kotlin/zig stacks the --fail-fast flag is silently dropped (validate scripts reject unknown flags). Contract violation. After code review, the dispatch logic is CORRECT — kotlin/zig skip --fail-fast intentionally with comments explaining why. The bug was only in the misleading message. Fix: update deprecation message to honestly state: - kotlin/zig do not accept --fail-fast - for those stacks, 'regret ci' runs all clusters (no early exit) No behavior change. No code logic change. Just accurate messaging. Full deprecation (removing the 'ci' case entirely) deferred to separate issue — it requires migrating the --init flag (which generates CI workflow files via ci-init.js) to another command like 'regret init --ci'. Closes #549
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Red team R-2 found that
regret cideprecation message claimed 'functionally identical to regret validate --fail-fast', but for kotlin/zig stacks the --fail-fast flag is silently dropped (validate scripts reject unknown flags). Contract violation.Root cause (after code review)
The dispatch logic is CORRECT — kotlin/zig skip
--fail-fastintentionally with comments explaining why (validate scripts reject unknown flags with exit 2). The bug was only in the misleading message.Fix
Update deprecation message to honestly state:
regret ciruns all clusters (no early exit)No behavior change. No code logic change. Just accurate messaging.
Why not full deprecation (option 3 from issue #549)
Full deprecation (removing the
cicase entirely) deferred to separate issue — it requires migrating the--initflag (which generates CI workflow files viaci-init.js) to another command likeregret init --ci. That's a breaking change that needs its own plan.Verification
node --check scripts/regret.js→ OKTest plan
Closes #549