[STUD-4406] Bump fsevents from 1.2.4 to 1.2.13#11
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [fsevents](https://github.com/fsevents/fsevents) from 1.2.4 to 1.2.13. - [Release notes](https://github.com/fsevents/fsevents/releases) - [Commits](fsevents/fsevents@v1.2.4...v1.2.13) --- updated-dependencies: - dependency-name: fsevents dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
|
Added notes on fork remediation and version bump to latest patch instead of 2.x. We likely still need this fork, but should at least move to fsevents v2. Putting it on a list of repos to better maintain. |
kevinbrock-wk
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fseventsdevelopment dependency from1.2.4to1.2.13viapackage-lock.json.fsevents1.x line because the current build toolchain resolves it throughchokidar@1.7.0, which declaresfsevents:^1.0.0.node-pre-gypsubtree that was pulled byfsevents@1.2.4;fsevents@1.2.13usesbindings+naninstead.Why not fsevents 2.x here?
fsevents@2.3.3is the npmlatestrelease, but it is not a drop-in lockfile bump for this fork. The dependency path is:webpack@1.15.0->watchpack@0.2.9->chokidar@1.7.0->fsevents:^1.0.0Moving to
fsevents@2.xcleanly would require updating the fork's legacy build/watch stack, especiallywebpack@1/watchpack@0/chokidar@1. That is a larger modernization than this security patch and carries more build risk.Analysis: migrating off this fork
The consuming repo,
Workiva/oc-builder, currently imports a fork-only named export:import { MouseBackend } from 'react-dnd-mouse-backend'The original npm package exposes a default backend factory instead:
import MouseBackend from 'react-dnd-mouse-backend'So replacing the fork with upstream
react-dnd-mouse-backend@1.0.0-rc.2would require at least an import change inpackages/onecloud-io/src/containers/DragDropProvider/DragDropProvider.js.However, the fork is not only an export-shape change. It also carries behavior changes that may be relevant to Chain Builder drag/drop parity:
Remove call to stop propagationchangelib/output committed for the GitHub dependency pathBecause of that, removing the fork should be treated as a follow-up migration rather than part of this dependency patch. A safe migration path would be:
oc-builderaround Chain Builder drag/drop behavior: drag start threshold, nested drop targets, escape cancel, right-click ignore, native/file-like drag handling if still supported, and click propagation around nodes/menus.DragDropProviderto the upstream default export and run the regression suite plus manual Chain Builder smoke tests.oc-builderover continuing to publish a separate fork. That would preserve behavioral parity where needed while making the dependency graph explicit in the consuming app.react-dnd-multi-backend, evaluate whether the adapter can wrap the upstream default factory or whether updating the DnD stack is the better long-term path.Validation
npm cisucceeds on this branch.npm run buildsucceeds and rebuildslib// UMD output without diffs.npm run lintstill fails on pre-existing style issues, mostlysemierrors in source files and a few existing warnings. This branch only changespackage-lock.json, so those lint failures are not introduced by this dependency bump.Follow-up
After this PR merges, update
oc-builder'spnpm-lock.yamlto pointgithub:Workiva/react-dnd-mouse-backendat the merged fork commit.