ci(tools): #449 Check for svelte errors in linting - #450
Merged
Conversation
Contributor
Author
|
Has to be tested first (the problem matchers for |
Deploying website with
|
| Latest commit: |
0a23b84
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eef9735a.website-7c4.pages.dev |
| Branch Preview URL: | https://mrgreentea-ci-449-check-for.website-7c4.pages.dev |
Contributor
Author
MrGreenTea
force-pushed
the
mrgreentea/ci/449-check-for-svelte-errors-in-lint
branch
from
October 25, 2024 12:15
1332453 to
faecffc
Compare
Contributor
Author
|
I think an astro matcher would be good too... |
MrGreenTea
force-pushed
the
mrgreentea/ci/449-check-for-svelte-errors-in-lint
branch
5 times, most recently
from
November 7, 2024 14:25
f810876 to
526f13f
Compare
Contributor
Author
|
I have tested both |
Han2-Ro
approved these changes
Nov 8, 2024
Han2-Ro
enabled auto-merge (squash)
November 8, 2024 15:21
Contributor
Author
|
I was just thinking that perhaps a separate job per lint would be good. I see that GitHub actions supports programmatic matrix now: We could then read out the Also if one linter finds an issue all other linters are stopped. See this pnpm issue |
MrGreenTea
force-pushed
the
mrgreentea/ci/449-check-for-svelte-errors-in-lint
branch
from
November 12, 2024 12:54
b47503e to
0a23b84
Compare
MrGreenTea
force-pushed
the
mrgreentea/ci/449-check-for-svelte-errors-in-lint
branch
from
November 12, 2024 12:55
0a23b84 to
bc1abb6
Compare
Han2-Ro
deleted the
mrgreentea/ci/449-check-for-svelte-errors-in-lint
branch
November 12, 2024 12:57
MrGreenTea
added a commit
that referenced
this pull request
Nov 12, 2024
#450 was merged automatically before I could push this
Merged
MrGreenTea
added a commit
that referenced
this pull request
Nov 12, 2024
#450 was merged automatically before I could push this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes: #449