Skip to content

Add accessibility improvements across all modal dialogs including ARIA roles, focus traps, and keyboard dismissal #876

Description

@Chucks1093

Summary

The app's modal dialogs are not fully accessible — they lack ARIA roles, do not trap focus inside the dialog, and cannot be dismissed with the Escape key in all cases. Fixing these issues across all modals would make the app usable with screen readers and keyboard-only navigation.

Scope

  • Add role='dialog', aria-modal='true', and aria-labelledby pointing to the modal title on every modal
  • Implement a focus trap that cycles Tab and Shift+Tab within the open modal
  • Ensure Escape key dismisses every modal regardless of which element has focus
  • Move focus to the first focusable element inside the modal on open and restore focus to the trigger on close
  • Add aria-live='polite' to success and error toast messages

Acceptance Criteria

  • All modals have role='dialog' and aria-modal='true'
  • Tab key cycles within the modal without escaping to the background
  • Escape key dismisses all modals
  • Focus moves to the first focusable element on modal open
  • Focus restored to the trigger element on modal close

ETA: 12 hours


Coordinate on Telegram

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave program

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions