[candidate_parameters] Fixed broken Family Information tab (add, render and delete) - #10514
Open
HachemJ wants to merge 2 commits into
Open
[candidate_parameters] Fixed broken Family Information tab (add, render and delete)#10514HachemJ wants to merge 2 commits into
HachemJ wants to merge 2 commits into
Conversation
Contributor
Author
|
I just realized there may be an issue with part of this implementation that I want to verify before asking for a full review. |
Contributor
|
Great, let me know when it's done! |
HachemJ
force-pushed
the
FixFamilyTabAddButton
branch
from
August 5, 2026 14:23
a42f4b9 to
c1ce511
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR updates family creation and deletion to use the internal CandidateID instead of CandID, and returns family members as an array to prevent errors in FamilyInfo.js, which expects an array when calling .push().
Testing instructions
Go to the Family Information tab: 'Candidate' -> 'Access profile' -> Click on any candidate’s PSCID -> Click on 'Candidate Info' -> 'Family Information' tab
Note: In some cases the Family tab is unaccessible if the study configuration does not have it enabled (check config module). You can also enable it from going to Admin --> Configuration --> select useFamily --> Submit.
Link(s) to related issue(s)