Fix: Remove broadcast-to-all-channels fallback in industry alerts#938
Merged
Conversation
Remove the fallback logic that sent articles to all active notification channels when no explicit routing was specified. Articles should only be sent to channels they've been explicitly routed to via notification_channel_ids. This prevents unrelated content from flooding specialized channels like #addie-moltbook. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the fallback logic that sent articles to all active notification channels when no explicit routing was specified. Articles should only be sent to channels they've been explicitly routed to.
Problem
Unrelated content was flooding specialized channels like #addie-moltbook due to the broadcast-to-all fallback when articles had no notification_channel_ids.
Solution
Changed the query condition from
OR k.notification_channel_ids IS NULL OR array_length(k.notification_channel_ids, 1) = 0to require explicit routing only:AND $2 = ANY(k.notification_channel_ids).🤖 Generated with Claude Code