chore: additional shadow dom tests and fixes - #9632
Open
snowystinger wants to merge 37 commits into
Open
Conversation
from pr 8991
5 tasks
5 tasks
5 tasks
|
Build successful! 🎉 |
5 tasks
|
Build successful! 🎉 |
# Conflicts: # packages/@react-aria/combobox/src/useComboBox.ts
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
# Conflicts: # packages/react-aria/src/interactions/utils.ts # packages/react-aria/test/focus/FocusScope.test.js # packages/react-aria/test/overlays/useOverlay.test.js
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
5 tasks
|
Build successful! 🎉 |
|
Build successful! 🎉 |
LFDanLu
reviewed
Aug 24, 2026
Comment on lines
-13
to
-14
| import '../src/page'; | ||
|
|
Member
There was a problem hiding this comment.
@snowystinger I think this was unneeded but not entirely sure what this was for? If it is the page.css, that gets imported by render already I believe
Member
Author
There was a problem hiding this comment.
I no longer recall, but that sounds about right
|
Build successful! 🎉 |
## API Changes
react-aria-components/react-aria-components:setInteractionModality-setInteractionModality {
- modality: Modality
- returnVal: undefined
-}/react-aria-components:Modality-Modality {
- M: undefined
-}@react-spectrum/s2/@react-spectrum/s2:Avatar Avatar {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
alt?: string
id?: string
isOverBackground?: boolean
size?: number | number | number | number | number | number | number | number | number | number | number | number | number | number | (number & {
-}) | `${number}lh` = 24
+}) = 24
slot?: string | null
src?: string
styles?: StylesPropWithoutWidth
}/@react-spectrum/s2:AvatarProps AvatarProps {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
alt?: string
id?: string
isOverBackground?: boolean
size?: number | number | number | number | number | number | number | number | number | number | number | number | number | number | (number & {
-}) | `${number}lh` = 24
+}) = 24
slot?: string | null
src?: string
styles?: StylesPropWithoutWidth
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10330
Pulling in various tests from all the PRs that have preceded this one.
First set from #8991
Need to figure out some oddities in the tests, esp Popover, why does it fail in React 16 and how does it pass in the non-shadow dom enabled testAnother issue solved, I've fixed focus in
preventFocusfor Combobox in real life. I was able to test it in the browser tests.I also noticed that RangeCalendar has a bug, one click will start and finish the range immediately. I've added a test and fixed this as well.
✅ Pull Request Checklist:
📝 Test Instructions:
You can test the ComboBox and DateRangePicker in the new aggregate S2 ShadowDOM story. If you find other bugs I don't mention or test in here, please still report it, but it'll be follow up elsewhere.
🧢 Your Project: